Bug 203577 - ClassFormatException viewing annotation with empty target annotation
Summary: ClassFormatException viewing annotation with empty target annotation
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.4 M2   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-17 06:50 EDT by Brock Janiczak CLA
Modified: 2007-09-18 10:19 EDT (History)
3 users (show)

See Also:


Attachments
Proposed fix (1.09 KB, patch)
2007-09-17 09:30 EDT, Olivier Thomann CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brock Janiczak CLA 2007-09-17 06:50:34 EDT
Attempting to view the following annotation in the class file editor

import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
import java.lang.annotation.Target;

@Target(value={})
@Retention(value=RetentionPolicy.RUNTIME)
public @interface NoTarget {

}

results in an empty editor and the attached exception.  The problem goes away when the @Target annotation is removed.

org.eclipse.jdt.core.util.ClassFormatException
    at org.eclipse.jdt.internal.core.util.Annotation.<init>(Annotation.java:55)
    at org.eclipse.jdt.internal.core.util.RuntimeVisibleAnnotationsAttribute.<init>(RuntimeVisibleAnnotationsAttribute.java:48)
    at org.eclipse.jdt.internal.core.util.ClassFileReader.<init>(ClassFileReader.java:261)
    at org.eclipse.jdt.internal.core.util.Disassembler.disassemble(Disassembler.java:290)
    at org.eclipse.jdt.internal.ui.javaeditor.ClassFileEditor$SourceAttachmentForm.updateCodeView(ClassFileEditor.java:403)
    at org.eclipse.jdt.internal.ui.javaeditor.ClassFileEditor$SourceAttachmentForm.createControl(ClassFileEditor.java:207)
    at org.eclipse.jdt.internal.ui.javaeditor.ClassFileEditor.verifyInput(ClassFileEditor.java:764)
    at org.eclipse.jdt.internal.ui.javaeditor.ClassFileEditor.createPartControl(ClassFileEditor.java:714)
    at org.eclipse.ui.internal.EditorReference.createPartHelper(EditorReference.java:661)
    at org.eclipse.ui.internal.EditorReference.createPart(EditorReference.java:426)
    at org.eclipse.ui.internal.WorkbenchPartReference.getPart(WorkbenchPartReference.java:592)
    at org.eclipse.ui.internal.EditorReference.getEditor(EditorReference.java:263)
    at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditorBatched(WorkbenchPage.java:2721)
    at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor(WorkbenchPage.java:2633)
    at org.eclipse.ui.internal.WorkbenchPage.access$12(WorkbenchPage.java:2625)
    at org.eclipse.ui.internal.WorkbenchPage$10.run(WorkbenchPage.java:2577)
    at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:67)
    at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2572)
    at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2556)
    at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2547)
    at org.eclipse.jdt.internal.ui.javaeditor.EditorUtility.openInEditor(EditorUtility.java:298)
    at org.eclipse.jdt.internal.ui.javaeditor.EditorUtility.openInEditor(EditorUtility.java:172)
    at org.eclipse.jdt.ui.actions.OpenAction.run(OpenAction.java:194)
    at org.eclipse.jdt.ui.actions.OpenAction.run(OpenAction.java:175)
    at org.eclipse.jdt.ui.actions.SelectionDispatchAction.dispatchRun(SelectionDispatchAction.java:268)
    at org.eclipse.jdt.ui.actions.SelectionDispatchAction.run(SelectionDispatchAction.java:244)
    at org.eclipse.jdt.internal.ui.navigator.OpenAndExpand.run(OpenAndExpand.java:50)
    at org.eclipse.ui.actions.RetargetAction.run(RetargetAction.java:220)
    at org.eclipse.ui.internal.navigator.CommonNavigatorManager$3.open(CommonNavigatorManager.java:183)
    at org.eclipse.jface.viewers.StructuredViewer$2.run(StructuredViewer.java:820)
    at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:37)
    at org.eclipse.core.runtime.Platform.run(Platform.java:857)
    at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:46)
    at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:193)
    at org.eclipse.jface.viewers.StructuredViewer.fireOpen(StructuredViewer.java:818)
    at org.eclipse.jface.viewers.StructuredViewer.handleOpen(StructuredViewer.java:1079)
    at org.eclipse.ui.navigator.CommonViewer.handleOpen(CommonViewer.java:353)
    at org.eclipse.jface.viewers.StructuredViewer$6.handleOpen(StructuredViewer.java:1183)
    at org.eclipse.jface.util.OpenStrategy.fireOpenEvent(OpenStrategy.java:263)
    at org.eclipse.jface.util.OpenStrategy.access$2(OpenStrategy.java:257)
    at org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java:297)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:938)
    at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3708)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3319)
    at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2389)
    at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2353)
    at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2219)
    at org.eclipse.ui.internal.Workbench$4.run(Workbench.java:466)
    at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:289)
    at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:461)
    at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
    at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:106)
    at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:169)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:106)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:76)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:363)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:508)
    at org.eclipse.equinox.launcher.Main.basicRun(Main.java:447)
    at org.eclipse.equinox.launcher.Main.run(Main.java:1173)
Comment 1 Olivier Thomann CLA 2007-09-17 09:30:01 EDT
Created attachment 78546 [details]
Proposed fix

Fix is trivial.
Comment 2 Olivier Thomann CLA 2007-09-17 09:31:24 EDT
Jérôme,

I would fix this for 3.4M2 since it appears in the Class file viewer. The fix is trivial.
Comment 3 Jerome Lanneluc CLA 2007-09-17 10:06:09 EDT
+1 for 3.4M2
Comment 4 Olivier Thomann CLA 2007-09-17 10:08:17 EDT
Released for 3.4M2.
Regression test added in org.eclipse.jdt.core.tests.compiler.regression.ClassFileReaderTest_1_5#test011
Comment 5 David Audel CLA 2007-09-18 10:19:29 EDT
Verified for 3.4M2 using build I20070918-0010