Bug 203124 - rse.doc.isv contains lot of html errors (HEAD version)
Summary: rse.doc.isv contains lot of html errors (HEAD version)
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.0.1   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-09-12 14:54 EDT by Olivier Thomann CLA
Modified: 2011-05-25 07:51 EDT (History)
0 users

See Also:

Attachments
Proposed fix (81.95 KB, patch)
2007-09-12 14:55 EDT, Olivier Thomann CLA 		no flags Details | Diff
Proposed fix (1.82 KB, patch)
2007-09-12 17:18 EDT, Olivier Thomann CLA 		mober.at+eclipse: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2007-09-12 14:54:50 EDT 
I got lot of indexing errors with version 1.0.1 of the rse.doc.user plugin. So I downloaded the rse.doc.isv and rse.doc.user plugins and I found lot of html errors in the code from HEAD.
I'll attach a patch that is fixing most of the problems.
Comment 1 Olivier Thomann CLA 2007-09-12 14:55:18 EDT 
Created attachment 78222 [details]
Proposed fix
Comment 2 Martin Oberhuber CLA 2007-09-12 15:08:12 EDT 
Awsome! Patch applied.

Your patch looks like 650 lines of change, but that's mostly due to CRLF / LF differences. In the Synchronize View, it was only 40 lines of change.

guide/tutorial/index.html was not matched when I applied the patch. What was your intention with that one? Could you check again on the updated HEAD?
Comment 3 Olivier Thomann CLA 2007-09-12 15:50:34 EDT 
I'll double-check the contents of HEAD later today.
Comment 4 Olivier Thomann CLA 2007-09-12 17:18:03 EDT 
Everything seems fine now except the index.html file in the guide/tutorial section. It is supposed to be a text file so CVS should convert the line delimiter on checkout.
However it seems that it contains unix line separators.
I will attach a patch that converts the line delimiter to DOS line delimiter on windows.
Comment 5 Olivier Thomann CLA 2007-09-12 17:18:28 EDT 
Created attachment 78234 [details]
Proposed fix
Comment 6 Martin Oberhuber CLA 2007-09-12 17:28:56 EDT 
Ha, that's funny. The file was marked ASCII -kkv in CVS, but it had Mac line endings (\r\r). I was unable to apply your patch on Windows, but I think I fixed it. Could you verify?
Comment 7 Olivier Thomann CLA 2007-09-12 17:53:22 EDT 
Yes, it looks ok.
Thanks for fixing this so quickly.