Community
Participate
Working Groups
+++ This bug was initially created as a clone of Bug #199773 +++ The file transfer mode preference page (Remote Systems > Files) has a listbox to select file extensions, with radio buttons coupled to the selection of the listbox. This is very unintuitive. A table showing extension + mode ("binary" | "text") should be used instead of the radio buttons coupled to selection. The "Add" Button should allow entering the pattern and the desired type at the same type. Pattern Matching should be possible not only by glob patterns ("*.xml") but also based on Eclipse Content Types, which use more sophisticated matchers (e.g. XML files are categorized based on contents <xml?). When pressing Add, the user should be able to chose the matcher (filename pattern or content type), and the file type. In the table of modes, the kind of matcher could be indicated by an Icon. The default transfer mode (when no matcher matches) could also be indicated in the table, with a special icon (matcher, name="default").
Also, the SystemFileTransferModeRegistry should not have any internal invisible default-defaults. Only the user-visible settings should be applied. This is related to bug #203357 (special handling of XML files).
In my fix for bug 208951, I've changed things so that we no longer have hidden file transfer mode preferences. Instead these are all explicitly shown in the preference page. The defaults are supplied via the new remoteFileType extension point. As for the XML always being treated as binary, I've taken out that code and simply defaulted XML to be binary in the preferences.
*** Bug 203357 has been marked as a duplicate of this bug. ***
I hadn't dealt with the usability issues so I'm reopening this for that.
Created attachment 82982 [details] patch with some UI improvements In this patch, I've made the following enhancements: -removed the binary/text mode radios (not for default though) -show binary/text cell editor combo in the table itself -icons for text are show, while for binary, we use binary decorator -a newly added file type automatically picks up the default file transfer mode
Created attachment 82984 [details] modified original patch to provide support for restore
The patch doesn't address all suggestions here. In particular it doesn't change the pattern matchers to use the more sophisticated Eclipse Content Types. I don't think the matchers for Team use this either though. Martin, could you take a look? I'm thinking that maybe we could put the matchers in a separate defect so that we can deal with the basic usability issues up-front.
I've committed the current changes to cvs. These also include a new reinit() method for the SystemFileTransferModeRegistry for restoring defaults.
Keyboard accessibility is a problem with the table. You can't change the File Transfer mode using the keyboard. The Team's preference page gets around this by adding a Change button that will switch between Binary and Ascii on the selected row in the table.
(In reply to comment #9) > Keyboard accessibility is a problem with the table. You can't change the File > Transfer mode using the keyboard. The Team's preference page gets around this > by adding a Change button that will switch between Binary and Ascii on the > selected row in the table. > I added a toggle button to address the switching between binary and text.
A fair amount of changes went in here to address the key usability issues. I see the "sophisticated" pattern matchers as being a separate enhancement that I don't have time too look at right now. Should we leave this defect open so that we can look at that or close it and open a separate enhancement request?
Close this and open a separate one.
I've opened a new defect to track the pattern matching enhancement: Bug 211120. I'm closing this one now.
