Bug 203059 - [Scanner Discovery] Compiler commands within sh -c '...' are ignored
Summary: [Scanner Discovery] Compiler commands within sh -c '...' are ignored
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-core (show other bugs)
Version: 4.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.0.1   Edit
Assignee: Anton Leherbauer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-09-12 08:25 EDT by Anton Leherbauer CLA
Modified: 2008-06-22 02:19 EDT (History)
2 users (show)

See Also:

Attachments
Patch solving this issue (6.65 KB, patch)
2007-09-13 12:01 EDT, Gerhard Schaber CLA 		bjorn.freeman-benson: iplog+
Details | Diff
Performance improvement update against applied patch (6.22 KB, patch)
2007-09-14 10:13 EDT, Gerhard Schaber CLA 		no flags Details | Diff
Performance improvement update against applied patch (6.12 KB, patch)
2007-09-14 10:46 EDT, Gerhard Schaber CLA 		bjorn.freeman-benson: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Leherbauer CLA 2007-09-12 08:25:34 EDT 
Compiler commands inside sh -c '...' are not recognized by the console parser.

E.g.

sh -c 'gcc -g -O0 -I"include abc" -c impl/testdummy.c'
Comment 1 Anton Leherbauer CLA 2007-09-12 08:44:05 EDT 
Created testcase BaseBOPConsoleParserTests._testCompilerCommandInsideShellInvocation_bug203059
Comment 2 Gerhard Schaber CLA 2007-09-13 12:01:42 EDT 
Created attachment 78327 [details]
Patch solving this issue

This is a proposal. I can't tell which impact this has on the performance. However it works fine with the test case and the application.
Comment 3 Anton Leherbauer CLA 2007-09-14 07:36:15 EDT 
Thanks Gerhard, the patch looks good. I tested with firefox and there was no measurable impact on performance.
Comment 4 Anton Leherbauer CLA 2007-09-14 07:44:09 EDT 
Fixed in 4.0.1 > 20070914.
Comment 5 Gerhard Schaber CLA 2007-09-14 10:13:23 EDT 
Created attachment 78428 [details]
Performance improvement update against applied patch

This reduces checks of lines that do not contain any compiler command. It gains, however, only a slight performance improvement.
Comment 6 Gerhard Schaber CLA 2007-09-14 10:46:43 EDT 
Created attachment 78433 [details]
Performance improvement update against applied patch