Bug 202239 - [templates] template context names should not be all lowercase
Summary: [templates] template context names should not be all lowercase
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.4 M2   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-05 04:09 EDT by Dani Megert CLA
Modified: 2007-09-11 11:48 EDT (History)
1 user (show)

See Also:

Attachments
proposed fix (3.34 KB, patch)
2007-09-11 10:23 EDT, Benno Baumgartner CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2007-09-05 04:09:03 EDT 
I20070904-0800.

The template context names should not be all lowercase.

java -> Java
javadoc -> Javadoc
swt -> SWT
Comment 1 dakshinamurthy.karra CLA 2007-09-05 04:17:40 EDT 
Adding to this, can we also use different strings for Ids and names? Though it does not cause problems, using fully qualified name for an id is recommended.

From TemplateContextType Java Doc:

 * Creates a context type with an identifier. The identifier must be unique, a qualified name is suggested.
Comment 2 Dani Megert CLA 2007-09-05 04:28:32 EDT 
Unfortunately we can't change that now as the ID is in the plugin.xml and hence can be used/referenced by others who contribute templates to it.
Comment 3 Benno Baumgartner CLA 2007-09-11 10:23:52 EDT 
Created attachment 78065 [details]
proposed fix

This fixes the issue by calling the default constructor in TemplateContextType which is allowed for subclass constructors.
Comment 4 Dani Megert CLA 2007-09-11 11:48:35 EDT 
Thanks Benno!

Fixed in HEAD.
Available in builds >= N20070912-0010.