Bug 201964 - [Schema][Editors] "Use" default value text field should be read-only when editor is not editable
Summary: [Schema][Editors] "Use" default value text field should be read-only when edi...
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M3   Edit
Assignee: Remy Suen CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed
Depends on:
Blocks:
 
Reported: 2007-08-31 17:26 EDT by Mike Pawlowski CLA
Modified: 2007-10-26 15:59 EDT (History)
4 users (show)

See Also:
caniszczyk: review? (caniszczyk)

Attachments
Screenshot (1.39 KB, image/png)
2007-09-04 23:01 EDT, Mike Pawlowski CLA 		no flags Details
Patch to call setEditable(boolean). (819 bytes, patch)
2007-10-02 19:30 EDT, Remy Suen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Pawlowski CLA 2007-08-31 17:26:23 EDT 
Eclipse Version >= Build id: I20070828-0800

Steps To Reproduce:

(1) Open "org.eclipse.pde.doc.user" manifest file
(2) Go to "Extensions" page
(3) Select "org.eclipse.help.toc"
(4) Click the "Open extension point schema" hyperlink
(5) Go to the "Definition" page
(6) Select "primary" attribute under "toc" element
    -> BUG:  "Use" default value text field is editable and
       can dirty the editor
    -> Note: Editor is not editable
    -> Note: Use is "default"
Comment 1 bartosz michalik CLA 2007-09-04 10:13:31 EDT 
works for me (use value is not editable) on  I20070625-1500
and on (3.4M1) I20070809-1105 with pde code from cvs HEAD included
Comment 2 Chris Aniszczyk CLA 2007-09-04 10:16:20 EDT 
Will have Mike double check here.
Comment 3 Mike Pawlowski CLA 2007-09-04 23:00:25 EDT 
This is still a problem.

Verified on I20070828-0800 and on I20070828-0800 + latest PDE code from HEAD.

Please note I am referring to the text field (editable) rather than the drop menu (non-editable).  See attached screenshot.

Easier way to reproduce is to start with a clean workspace and access the schema by opening 'org.eclipse.help' from the "Plug-ins" view.
Comment 4 Mike Pawlowski CLA 2007-09-04 23:01:14 EDT 
Created attachment 77676 [details]
Screenshot
Comment 5 Remy Suen CLA 2007-10-02 19:30:03 EDT 
Created attachment 79602 [details]
Patch to call setEditable(boolean).
Comment 6 Chris Aniszczyk CLA 2007-10-02 20:48:24 EDT 
cool!
Comment 7 Brian Bauman CLA 2007-10-03 00:10:47 EDT 
Remy, looks good to me.  Very simple and elegant ;-)

So how come we don't have a photo for you on our contributors page?  If you can, send us a head shot with a leafy background and we will add you to our prestigious list (http://www.eclipse.org/pde/pde-ui/committers/committers.php)
Comment 8 Chris Aniszczyk CLA 2007-10-26 15:59:27 EDT 
verified in >I20071023