Bug 201880 - Plugin Registry view shows incorrect information from other versions
Summary: Plugin Registry view shows incorrect information from other versions
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 3.4 M2   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-08-31 07:47 EDT by Mike Haller CLA
Modified: 2007-09-18 16:11 EDT (History)
3 users (show)

See Also:

Attachments
Suggested bugfix (1.21 KB, patch)
2007-08-31 07:47 EDT, Mike Haller CLA 		no flags Details | Diff
Screenshot showing the problem (13.34 KB, image/png)
2007-08-31 08:44 EDT, Mike Haller CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Haller CLA 2007-08-31 07:47:45 EDT 
Created attachment 77453 [details]
Suggested bugfix

Build ID: I20070625-1500 (Affects cvs head as of today too)

Steps To Reproduce:
1. Install a plugin with multiple versions in a packaged Eclipse installation (NOT in Runtime Workbench!)
2. Open the view PDE Runtime > Plug-In Registry (Registry Browser)
3. Expand both plugin versions. Both show same location although they should differ.

Example:
org.example.plugin_1.0.0 points to plugins/org.example.plugin_1.0.0.jar
org.example.plugin_1.0.1 points to plugins/org.example.plugin_1.0.0.jar
org.example.plugin_1.0.2 points to plugins/org.example.plugin_1.0.0.jar
org.example.plugin_1.0.3 points to plugins/org.example.plugin_1.0.0.jar

More information:
This is a bug in the UI only!

The RegistryBrowserContentProvider identifes the items to be displayed solely on the symbolic name of a Bundle and does not take the version into account. The content provider should use another identification of the bundle, e.g. the bundle reference itself or at least the bundleId.

Fix is easy: fPluginMap should contain <BundleId,Object[]> instead of <BundleSymbolicName,Object[]>. See attached patch.
Comment 1 Mike Haller CLA 2007-08-31 08:44:13 EDT 
Created attachment 77457 [details]
Screenshot showing the problem
Comment 2 Chris Aniszczyk CLA 2007-08-31 13:16:40 EDT 
Want to take a look at this one Janek :)?
Comment 3 Janek Lasocki-Biczysko CLA 2007-08-31 13:29:51 EDT 
Sure thing, right up my alley as of recently..
Comment 4 Janek Lasocki-Biczysko CLA 2007-08-31 18:13:54 EDT 
Thanks for the patch Mike - tested and applied.