Bug 201878 - [quick fix] improve cursor jumping on CTRL + 1
Summary: [quick fix] improve cursor jumping on CTRL + 1
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M5   Edit
Assignee: Benno Baumgartner CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 42086 201872 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-08-31 06:49 EDT by Martin Aeschlimann CLA
Modified: 2008-01-21 09:18 EST (History)
3 users (show)

See Also:
daniel_megert: review+


Attachments
proposed fix (10.22 KB, patch)
2008-01-15 10:45 EST, Benno Baumgartner CLA
no flags Details | Diff
fix (14.04 KB, patch)
2008-01-17 06:27 EST, Benno Baumgartner CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2007-08-31 06:49:23 EDT
3.3

If CTRL + 1 finds warnings or errors on the same line, it jumps to the closest error and offers proposals for that error.

Users would like to have more control over that:
- they didn't want to fix the closest error but do a quick assist at the cursor location (see bug 201872)
- they want to fix a different bug on the same line (or close to the cursor)
- they want to fix an error on a different line
Comment 1 Martin Aeschlimann CLA 2007-09-17 07:22:23 EDT
*** Bug 201872 has been marked as a duplicate of this bug. ***
Comment 2 Benno Baumgartner CLA 2008-01-15 10:45:34 EST
Created attachment 86940 [details]
proposed fix

'Ctrl-1' to go to original position, if position was updated. The multi quick fix message wins over this message (if any).

Dani, more for you to review;-) The fix is almost trivial, maybe too trivial?
Comment 3 Dani Megert CLA 2008-01-16 11:31:49 EST
Patch goes into the right direction. I've committed the Platform Text change (added missing @since 3.4 tag and removed "(non-Javadoc)" as this will be need anyway.

Some remaining issues:
- If the current position is a valid quick fix position (or there's no
  error on that line at all) then pressing Ctrl+1 again closes and reopens
  the same list. This should not happen.
- Status text should read "Press .... (like in content assist and quick views)
- The key binding must not be hard-coded. This will also fix the current
  usage of '-' instead of '+'.
- After going to original position status text should read:
  "Press 'KEY BINDING' to go to closest problem"
Comment 4 Dani Megert CLA 2008-01-16 11:46:11 EST
*** Bug 42086 has been marked as a duplicate of this bug. ***
Comment 5 Benno Baumgartner CLA 2008-01-17 06:27:13 EST
Created attachment 87147 [details]
fix
Comment 6 Dani Megert CLA 2008-01-21 09:18:26 EST
Last patch committed with minor adjustments.
Available in builds > N20080121-0010.