Bug 201867 - [terminal-ssh] Add port to SSH connection summary string
Summary: [terminal-ssh] Add port to SSH connection summary string
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: Terminal (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P4 minor (vote)
Target Milestone: 2.0.1   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-08-31 04:26 EDT by Mikhail Kalugin CLA
Modified: 2011-05-25 09:40 EDT (History)
1 user (show)

See Also:

Attachments
Patch for SshConnectorInfo (813 bytes, patch)
2007-08-31 04:26 EDT, Mikhail Kalugin CLA 		mober.at+eclipse: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Kalugin CLA 2007-08-31 04:26:41 EDT 
Created attachment 77444 [details]
Patch for SshConnectorInfo

Now SSH connection summary string has form <host>:<user>. I think that <user>@<host>:<port> would be better presentation for connection info. It has more popular syntax and contains more information. Does anybody has any objection about it? 

The patch that fixes string is attached.
Comment 1 Martin Oberhuber CLA 2007-09-03 11:20:39 EDT 
Patch applied with slight modification - adding the "port" only if it's not the default (22). Thanks!
Comment 2 Martin Oberhuber CLA 2007-09-03 14:02:40 EDT 
BTW, when submitting another patch you would make us the work slightly easier if you could please

1. Add a line in the file header comment for your contribution, such that it is
   shipped with the patch. This time, I added the following for you:

 * Mikhail Kalugin <fourdman@xored.com> - [201867] Improve Terminal SSH connection summary string

2. Provide your patch as an "Eclipse Workspace Patch" (created with Team > 
   Create Patch...) -- this way I don't have to look for the right project

3. Add the disclaimer in the bugzilla comment as outlined here:
   http://www.eclipse.org/dsdp/tm/development/committer_howto.php#external_contrib

Thanks!