Bug 201572 - [Manifest][Editors] Package Friends are not selected after addition
Summary: [Manifest][Editors] Package Friends are not selected after addition
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M6   Edit
Assignee: Benjamin Cabé CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-08-29 10:26 EDT by Noam Chitayat CLA
Modified: 2008-02-12 20:36 EST (History)
2 users (show)

See Also:

Attachments
Proposed patch to fix this bug (988 bytes, patch)
2008-02-12 13:37 EST, Benjamin Cabé CLA 		no flags Details | Diff
mylyn/context/zip (760 bytes, application/octet-stream)
2008-02-12 13:37 EST, Benjamin Cabé CLA 		no flags Details
Updated patch (2.78 KB, patch)
2008-02-12 14:35 EST, Benjamin Cabé CLA 		no flags Details | Diff
mylyn/context/zip (839 bytes, application/octet-stream)
2008-02-12 14:35 EST, Benjamin Cabé CLA 		no flags Details
org.eclipse.pde.ui.patch (2.82 KB, patch)
2008-02-12 20:34 EST, Chris Aniszczyk CLA 		no flags Details | Diff
mylyn/context/zip (1.00 KB, application/octet-stream)
2008-02-12 20:34 EST, Chris Aniszczyk CLA 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Chitayat CLA 2007-08-29 10:26:28 EDT 
1. Create a new Plug-in Project or open an existing one with exported packages.

2. Select a package that is either internal or visible. (It must have been that way before you opened the manifest editor)

3. In the Package Visibility section on the top-right, ensure that the "hidden from all plug-ins except" radio button is selected.

4. Click "Add..." and add a plug-in to this list.
--> Bug: The added plug-in is not selected
Comment 1 Benjamin Cabé CLA 2008-02-12 12:44:41 EST 
I'll have a look at this bug
Comment 2 Benjamin Cabé CLA 2008-02-12 13:37:35 EST 
Created attachment 89528 [details]
Proposed patch to fix this bug
Comment 3 Benjamin Cabé CLA 2008-02-12 13:37:38 EST 
Created attachment 89529 [details]
mylyn/context/zip
Comment 4 Chris Aniszczyk CLA 2008-02-12 13:52:05 EST 
It didn't work :(
Comment 5 Benjamin Cabé CLA 2008-02-12 14:19:13 EST 
Arg, I corrected another small bug occuring on windows only (exported package selected but not "focused" when added in the list), not the one described in the steps ;) !..
Comment 6 Benjamin Cabé CLA 2008-02-12 14:35:28 EST 
Created attachment 89543 [details]
Updated patch
Comment 7 Benjamin Cabé CLA 2008-02-12 14:35:31 EST 
Created attachment 89544 [details]
mylyn/context/zip
Comment 8 Chris Aniszczyk CLA 2008-02-12 20:34:46 EST 
Created attachment 89582 [details]
org.eclipse.pde.ui.patch

made a slight change in regards to setting focus, we were selecting items in the friend's viewer but not actually giving it focus so your keyboard would be useless.
Comment 9 Chris Aniszczyk CLA 2008-02-12 20:34:52 EST 
Created attachment 89583 [details]
mylyn/context/zip
Comment 10 Chris Aniszczyk CLA 2008-02-12 20:36:06 EST 
Thanks for the patch Ben! :)

Another one bites the dust!
Comment 11 Chris Aniszczyk CLA 2008-02-12 20:36:34 EST 
Another one bites the dust >:)!