Bug 201566 - XMLContentAssistProcessor, ExtensionAttributePointDetector make unnecessary casts
Summary: XMLContentAssistProcessor, ExtensionAttributePointDetector make unnecessary c...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M2   Edit
Assignee: Remy Suen CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed
Depends on:
Blocks:
 
Reported: 2007-08-29 10:07 EDT by Noam Chitayat CLA
Modified: 2007-08-31 13:05 EDT (History)
3 users (show)

See Also:

Attachments
Patch to remove the casts. 'Save Actions' is your friend, though. You can configure it to remove unnecessary casts, by the way. ;) (2.39 KB, patch)
2007-08-29 14:34 EDT, Remy Suen CLA 		no flags Details | Diff
mylyn/context/zip (752 bytes, application/octet-stream)
2007-08-29 15:13 EDT, Chris Aniszczyk CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Chitayat CLA 2007-08-29 10:07:01 EDT 
In
org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/contentassist	XMLContentAssistProcessor.java:

Unnecessary cast from IDocumentAttributeNode to IDocumentElementNode at line 245
Unnecessary cast from IDocumentAttributeNode to IDocumentRange at line 323
Unnecessary cast from IDocumentAttributeNode to IDocumentRange at line 331
Unnecessary cast from IDocumentAttributeNode to IDocumentRange at line 421

In
org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin	ExtensionAttributePointDectector.java:

Unnecessary cast from IDocumentAttributeNode to IDocumentElementNode at line 132
Comment 1 Chris Aniszczyk CLA 2007-08-29 10:15:54 EDT 
Where's Janek :)?
Comment 2 Remy Suen CLA 2007-08-29 14:34:14 EDT 
Created attachment 77281 [details]
Patch to remove the casts. 'Save Actions' is your friend, though. You can configure it to remove unnecessary casts, by the way. ;)
Comment 3 Chris Aniszczyk CLA 2007-08-29 15:13:26 EDT 
thanks Remy :)
Comment 4 Chris Aniszczyk CLA 2007-08-29 15:13:30 EDT 
Created attachment 77288 [details]
mylyn/context/zip
Comment 5 Janek Lasocki-Biczysko CLA 2007-08-31 13:05:59 EDT 
Hehe, just noticed this now.. too late!