Description Amy Wu 2007-08-28 17:15:19 EDT

jsp action validator performance can be improved

1)
background: the validator currently attempts to validate all action tags by first checking if the current tag has a "known" jsp prefix.  it then calls model.getIndexedRegion() which is a costly method to call.  after that, it attempts to get the content model for the node and verify the tag.

problem: a "known" jsp prefix is basically any custom tag declared for the jsp whether the tag library actually exists or not (ie whether the uri for the custom tag's taglib directive actually resolves to anything) so if you have a file full of custom tags, but the taglib directive for the custom tag doesnt actually point to anything, you end up calling model.getIndexedRegion() a lot only to result to no validation can be done (looking up content model for tag will reveal the custom tag does not really resolve to anything)

solution: when compiling the list of "known" jsp prefixes, make sure to only include prefixes for tag libraries that actually resolve to something

2) 
problem: during source validation, when a tag is modified, the validator passes in 2 dirty regions, the start tag region and the end tag region.  the jsp action validator looks up the structureddocumentregion for both and gets the same region and ends up validating the same tag twice.

solution: fix would be to check if the region passed in is part of the start tag.  if not, no need to validate.