Bug 201435 - [Manifest][Editors] Add a decoration or overlay to packages that are internal
Summary: [Manifest][Editors] Add a decoration or overlay to packages that are internal
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M4   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2007-08-28 11:28 EDT by Jeff McAffer CLA
Modified: 2007-12-11 13:38 EST (History)
4 users (show)

See Also:


Attachments
8x7 pixel happy face (186 bytes, image/png)
2007-08-28 13:32 EDT, Noam Chitayat CLA
no flags Details
New happy face. (835 bytes, image/gif)
2007-08-28 14:01 EDT, Noam Chitayat CLA
no flags Details
org.eclipse.pde.ui.patch (4.18 KB, patch)
2007-11-17 17:25 EST, Chris Aniszczyk CLA
no flags Details | Diff
mylyn/context/zip (994 bytes, application/octet-stream)
2007-11-17 17:25 EST, Chris Aniszczyk CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff McAffer CLA 2007-08-28 11:28:01 EDT
It would be great to have a UI way of setting exported packages as x-internal or x-friends.  right now people have to remember the obscure syntax and hope to get it right.  Ther eis also no indication on the dependencies tab as to which packages are internal/friends etc.
Comment 1 Brian Bauman CLA 2007-08-28 11:50:33 EDT
Jeff, I am so hurt :(

This already exists.  You are familiar with the Exported Packages section on the Runtime tab.  When you select a package, the information in the Package Visibility section enables.  It is in this section you can do just that.

By default, every package is public.  To make it internal, select the "hidden from all plug-ins except" radio button.  If no bundles are added to the list, it will be marked as internal.  Once the user adds bundles to that table, the exported package will specify each listed bundle as an x-friend.
Comment 2 Dejan Glozic CLA 2007-08-28 11:56:10 EDT
Yeah, Jeff, really :-). Even I know about these features in the editor (and used them to make some friends :-).
Comment 3 Jeff McAffer CLA 2007-08-28 12:09:31 EDT
you are indeed right, and I did indeed know this.  I did however forget.  sigh.

Having said that...
- it would still be good to have some sort of decoration in the exported package list
- the visibility section is somewhat disjoint from the exported package list.  Is there someway we would add some visual cues?  For exampl,e when I click through the packages all that may change in the visibility area is the radio button.  I was clicking around and never noticed the button changing so never really even looked at the section.  
- My natural instinct was to right click and use the Properties entry.  That give the promise of being able to tweak the setting but only exposes version.

Anyway, I agree that (modulo the first point above) the desired behaviour is there.  Looking for how we can tie it together in a more obvious way.  then again, it could just be me...
Comment 4 Dejan Glozic CLA 2007-08-28 12:23:52 EDT
+1 for the decoration/overlay if packages to indicate internal/friends status.
Comment 5 Chris Aniszczyk CLA 2007-08-28 12:32:18 EDT
+1 if the friends decoration is a happy face.
Comment 6 Dejan Glozic CLA 2007-08-28 13:23:48 EDT
Chris, I have seen graphic designers pull off miracles with a few pixels, but even they will struggle to draw a happy face in an 8x7 overlay :-).
Comment 7 Mike Pawlowski CLA 2007-08-28 13:31:37 EDT
+1

Photoshop is always up to the task.
However, I can't guarantee the happy face will not look like a sad face ;)
Comment 8 Noam Chitayat CLA 2007-08-28 13:32:17 EDT
Created attachment 77155 [details]
8x7 pixel happy face

Assuming Dejan's spec (8x7) was correct, this should do the trick. :P
Comment 9 Chris Aniszczyk CLA 2007-08-28 13:33:58 EDT
haha
Comment 10 Dejan Glozic CLA 2007-08-28 13:39:40 EDT
I woudn't take for granted anything Dejan says these days - better check other overlays in the library :-).
Comment 11 Noam Chitayat CLA 2007-08-28 13:45:20 EDT
(In reply to comment #10)
> I woudn't take for granted anything Dejan says these days - better check other
> overlays in the library :-).
> 

You're right; 7x8, not 8x7, and I should've saved as .gif. Damn. :)
Comment 12 Noam Chitayat CLA 2007-08-28 14:01:08 EDT
Created attachment 77158 [details]
New happy face.

Revised patches I can understand. But I can't believe I'm revising a happy face.
Comment 13 Wassim Melhem CLA 2007-08-28 14:34:09 EDT
Stop screwing around!!!
Comment 14 Chris Aniszczyk CLA 2007-11-17 16:38:24 EST
Optional plug-ins have a proper overlay now with bug 210180 fixed for those who want to be in the know.
Comment 15 Chris Aniszczyk CLA 2007-11-17 17:23:01 EST
Changing this bug to only deal with internal, opened bug 210183 to handle the x-friends case since I'm having trouble visualizing an icon other than a happy face for it.
Comment 16 Chris Aniszczyk CLA 2007-11-17 17:25:42 EST
Created attachment 83167 [details]
org.eclipse.pde.ui.patch

Adds an overlay icon to export packages that are internal. The overlay is similar to JDT's notion of protected members (ie., yellow diamond).
Comment 17 Chris Aniszczyk CLA 2007-11-17 17:25:48 EST
Created attachment 83168 [details]
mylyn/context/zip
Comment 18 Chris Aniszczyk CLA 2007-11-17 17:26:20 EST
fixed in HEAD, >20071117
Comment 19 Brian Bauman CLA 2007-12-11 13:38:31 EST
verified on I20071211-0010