Community
Participate
Working Groups
When working with the Target Editor's Content page, checking the "Include all plug-ins from the specified target" results in: 1. The Plug-ins tab and the Features tab shown as empty. 2. The Plug-ins tab and the Features tab are disabled. This is confusing and inconsistent with other parts of the Eclipse IDE. Instead, I'd like to see: 1. The contents of the Plug-ins tab and the Features tab being disabled. 2. The Plug-ins tab and the Features tab remaining enabled. As the editor works today, real content from the .target file is not displayed, which is confusing. For example, it is always a surprise when you uncheck the "Include all plug-ins from the specified target" checkbox to find the Plug-ins and Features tabs already populated. A candidate for bugday, perhaps.
Thoughts Brian?
Sorry for the confusion Simon. Can you point me to other areas in the IDE which we appear to break consistency? I know there are some areas with radio buttons which exhibit the behavior you speak of. Our initial design did not include radio buttons so it is not clear to user that it is more of an "either/or" choice. Maybe the enhancement might be two radio buttons. One to "Include all plug-ins from the specified target" and another to "Include only plug-ins listed below". With this behavior, I could see the enable/disable strategy you suggested. The user would know the content in the table will not be used since the radio buttons make it either/or.
Created attachment 77763 [details] Screenshot
The IDE is full of example of where a single checkbox and multiple radio buttons are used. The goal here is to not hide the contents of the XML file. I have attached a file that shows a bunch of examples from various dialogs.
PDE Slayer is back ;)
Adam, can you take a look at this and fix it up. The choices to include all the plug-ins from the target platform, or to include only the plug-ins below are mutually exclusive. Therefore, we should use radio buttons to prevent the confusion and clearly spell out to the user their exclusions. As long as the user understands the content in the table does not matter when they choose the "include all plug-ins from the specified target", I have no problems with keeping the content in the table and just disabling it.
Created attachment 77841 [details] patch Turns the checkbox into two radio buttons. When the "all plug-ins in the target" box is selected, the table will remain populated as it was before, but will be disabled along with the rest of the controls on the page.
Adam, please make sure that the user can still flip between the Plug-ins page and the Features page while the "all plug-ins in the target" box is selected. The goal here is to never hide the contents of the .target file, but rather communicate the meaning. Thanks.
Applied patch with a few very minor changes. 1. Arranged the radio buttons vertically instead of horizontally. This highlighted the link between the new radio button and the table below. 2. Made one line change to allow for functionality specified in comment 8. 3. Added selectionListener to only one radio button. When added to both buttons, the listener is called twice, once for the deselect event on the first button and a second time for the select event on the second button. By adding only to one button, we get only one event, either a select or deselect event. Thanks for the quick turn around on this Adam! Your contributions will definitely be missed.
