Bug 201308 - BinaryRepositoryProvider makes deprecated calls
Summary: BinaryRepositoryProvider makes deprecated calls
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M2   Edit
Assignee: Fabio Mancinelli CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed
Depends on:
Blocks:
 
Reported: 2007-08-27 15:17 EDT by Chris Aniszczyk CLA
Modified: 2007-08-27 17:45 EDT (History)
0 users

See Also:

Attachments
A patch to fix the bug (2.31 KB, patch)
2007-08-27 17:37 EDT, Fabio Mancinelli CLA 		no flags Details | Diff
org.eclipse.pde.core.patch (2.92 KB, patch)
2007-08-27 17:43 EDT, Chris Aniszczyk CLA 		no flags Details | Diff
mylyn/context/zip (768 bytes, application/octet-stream)
2007-08-27 17:43 EDT, Chris Aniszczyk CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2007-08-27 15:17:16 EDT 
org.eclipse.pde.internal.core.BinaryRepositoryProvider.java

Severity and Description	Path	Resource	Location	Creation Time	Id
The type IFileModificationValidator is deprecated	org.eclipse.pde.core/src/org/eclipse/pde/internal/core	BinaryRepositoryProvider.java	line 15	1188224978718	132725
The type IFileModificationValidator is deprecated	org.eclipse.pde.core/src/org/eclipse/pde/internal/core	BinaryRepositoryProvider.java	line 30	1188224978718	132726
The type IFileModificationValidator is deprecated	org.eclipse.pde.core/src/org/eclipse/pde/internal/core	BinaryRepositoryProvider.java	line 122	1188224978718	132727
The type IFileModificationValidator is deprecated	org.eclipse.pde.core/src/org/eclipse/pde/internal/core	BinaryRepositoryProvider.java	line 170	1188224978718	132728
Comment 1 Fabio Mancinelli CLA 2007-08-27 17:37:31 EDT 
Created attachment 77074 [details]
A patch to fix the bug

Changed IFileModificationValidator with subclasses of FileModificationValidator.
Modified variable types accordingly.
Implemented getFileModificationValidator2() to return the correct type.

Fabio
Comment 2 Chris Aniszczyk CLA 2007-08-27 17:43:54 EDT 
Created attachment 77075 [details]
org.eclipse.pde.core.patch

Updated patch with contributor info, and removed the older getFileModificationValidator method that isn't used anymore.
Comment 3 Chris Aniszczyk CLA 2007-08-27 17:43:57 EDT 
Created attachment 77076 [details]
mylyn/context/zip
Comment 4 Chris Aniszczyk CLA 2007-08-27 17:45:23 EDT 
Committed to HEAD.

Thanks Fabio. We now need a picture from you to include on our famous PDE Contributor webpage:
	http://www.eclipse.org/pde/pde-ui/committers/committers.php