Bug 201306 - XMLErrorReporter makes deprecated calls
Summary: XMLErrorReporter makes deprecated calls
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M2   Edit
Assignee: Fabio Mancinelli CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed
Depends on:
Blocks:
 
Reported: 2007-08-27 15:00 EDT by Chris Aniszczyk CLA
Modified: 2007-08-27 19:16 EDT (History)
0 users

See Also:

Attachments
A patch to fix the bug (1.50 KB, patch)
2007-08-27 17:14 EDT, Fabio Mancinelli CLA 		no flags Details | Diff
mylyn/context/zip (1.03 KB, application/octet-stream)
2007-08-27 19:14 EDT, Chris Aniszczyk CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2007-08-27 15:00:59 EDT 
org.eclipse.pde.internal.core.builders.XMLErrorReporter.java

Severity and Description	Path	Resource	Location	Creation Time	Id
The method connect(IPath, IProgressMonitor) from the type IFileBufferManager is deprecated	org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders	XMLErrorReporter.java	line 94	1188224977953	132716
The method disconnect(IPath, IProgressMonitor) from the type IFileBufferManager is deprecated	org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders	XMLErrorReporter.java	line 96	1188224977953	132718
The method getTextFileBuffer(IPath) from the type ITextFileBufferManager is deprecated	org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders	XMLErrorReporter.java	line 95	1188224977953	132717
Comment 1 Fabio Mancinelli CLA 2007-08-27 17:14:38 EDT 
Created attachment 77072 [details]
A patch to fix the bug

Just added LocationKind.NORMALIZE to method calls.

I used LocationKind.NORMALIZE after looking at
org.eclipse.core.internal.filebuffers.TextFileBufferManager.connect/disconnect/getTextFileBuffer

TextFileBufferManager, in fact, is the base object returned by
FileBuffers.getTextFileBufferManager() and that is used in the lines mentioned
in the bug report.

Deprecated method calls are equivalent to calling the suggested method with the
LocationKind.NORMALIZE parameter

Fabio
Comment 2 Chris Aniszczyk CLA 2007-08-27 17:17:42 EDT 
reassigning to you Fabio.

Will look at this patch tonight.
Comment 3 Chris Aniszczyk CLA 2007-08-27 19:14:40 EDT 
committed to HEAD.

Thanks Fabio!
Comment 4 Chris Aniszczyk CLA 2007-08-27 19:14:42 EDT 
Created attachment 77080 [details]
mylyn/context/zip
Comment 5 Chris Aniszczyk CLA 2007-08-27 19:16:51 EDT 
updating target milestone