Bug 201129 - External Discouraged Access warnings in o.e.d.sqltools.common.ui
Summary: External Discouraged Access warnings in o.e.d.sqltools.common.ui
Status: ASSIGNED
Alias: None
Product: Data Tools
Classification: Tools
Component: SQL Editor Framework (show other bugs)
Version: 1.5   Edit
Hardware: All Windows XP
: P3 major (vote)
Target Milestone: future   Edit
Assignee: Hui Cao CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2007-08-24 15:55 EDT by John Graham CLA
Modified: 2008-04-28 23:26 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Graham CLA 2007-08-24 15:55:37 EDT
org/eclipse/datatools/sqltools/common/ui/dialog/SaveAsDialog.java
-----------------------------------------------------------------
line 271, The field Question from the type IDEWorkbenchMessages is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 119, The field SAVE_AS_DIALOG from the type IIDEHelpContextIds is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 191, The field SaveAsDialog_file from the type IDEWorkbenchMessages is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 191, The field SaveAsDialog_fileLabel from the type IDEWorkbenchMessages is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 383, The field SaveAsDialog_message from the type IDEWorkbenchMessages is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 265, The field SaveAsDialog_overwriteQuestion from the type IDEWorkbenchMessages is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 118, The field SaveAsDialog_text from the type IDEWorkbenchMessages is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 133, The field SaveAsDialog_title from the type IDEWorkbenchMessages is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 44, The type IDEWorkbenchMessages is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 118, The type IDEWorkbenchMessages is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 133, The type IDEWorkbenchMessages is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 191, The type IDEWorkbenchMessages is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 191, The type IDEWorkbenchMessages is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 265, The type IDEWorkbenchMessages is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 265, The type IDEWorkbenchMessages is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 271, The type IDEWorkbenchMessages is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 383, The type IDEWorkbenchMessages is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 45, The type IIDEHelpContextIds is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 119, The type IIDEHelpContextIds is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar

org/eclipse/datatools/sqltools/common/ui/resource/ContainerSelectionGroup.java
-------------------------------------------------------------------------------
line 265, The constructor ContainerContentProvider() is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 80, The field ContainerGroup_message from the type IDEWorkbenchMessages is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 81, The field ContainerGroup_selectFolder from the type IDEWorkbenchMessages is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 266, The method showClosedProjects(boolean) from the type ContainerContentProvider is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 49, The type ContainerContentProvider is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 265, The type ContainerContentProvider is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 265, The type ContainerContentProvider is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 48, The type IDEWorkbenchMessages is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 80, The type IDEWorkbenchMessages is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 81, The type IDEWorkbenchMessages is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar

org/eclipse/datatools/sqltools/common/ui/resource/CreateFolderAction.java
-------------------------------------------------------------------------
line 75, The field CREATE_FOLDER_ACTION from the type IIDEHelpContextIds is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 90, The field NEW_FOLDER_WIZARD from the type IIDEHelpContextIds is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 27, The type IIDEHelpContextIds is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 75, The type IIDEHelpContextIds is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 90, The type IIDEHelpContextIds is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar

org/eclipse/datatools/sqltools/common/ui/resource/WizardNewFileCreationPage.java
------------------------------------------------------------------------------
line 162, The constructor CreateLinkedResourceGroup(int, Listener, CreateLinkedResourceGroup.IStringValue) is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 184, The field NEW_FILE_WIZARD_PAGE from the type IIDEHelpContextIds is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 495, The method createContents(Composite) from the type CreateLinkedResourceGroup is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 602, The method validateLinkLocation(IResource) from the type CreateLinkedResourceGroup is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 56, The type CreateLinkedResourceGroup is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 98, The type CreateLinkedResourceGroup is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 162, The type CreateLinkedResourceGroup is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 288, The type CreateLinkedResourceGroup is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 306, The type CreateLinkedResourceGroup is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 55, The type IIDEHelpContextIds is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
	line 184, The type IIDEHelpContextIds is not accessible due to restriction on required library org.eclipse.ui.ide_3.3.0.I20070620.jar
Comment 1 John Graham CLA 2007-08-24 16:11:19 EDT
Do not change the severity -- external discouraged access warnings have uniformly been marked as "major" in DTP Ganymede by the PMC.
Comment 2 Hui Cao CLA 2008-02-19 08:06:33 EST
Removed all Discouraged Access warnings except references to ContainerContentProvider and CreateLinkedResourceGroup
Comment 3 Hui Cao CLA 2008-02-25 05:03:33 EST
The reference to CreateLinkedResourceGroup and ContainerContentProvider is to add a "Create Project..." button in the "New SQL File" wizard. Since these components are not meant to be extended, it's not fair asking Eclipse framework team to expose them as API. What we can do is:
1. Remove this feature and just use the default Eclipse new file wizard. But since this feature comes from a customer's requirement before we contribute code to DTP, and it does help user to create a project on the fly, I don't like this choice.
2. Copy the code to DTP. Considering the amount of the code, this is not a good idea either.
3. Request Eclipse framework team to enhance the component. This is probably the best choice we have. https://bugs.eclipse.org/bugs/show_bug.cgi?id=220159 has been created for this enhancement.
Comment 4 Hui Cao CLA 2008-04-28 23:26:31 EDT
Waiting for 220159...