Community
Participate
Working Groups
org/eclipse/datatools/connectivity/ui/actions/ViewPropertyAction.java --------------------------------------------------------------------- line 109, The constructor PropertyDialog(Shell, PreferenceManager, ISelection) is not accessible due to restriction on required library org.eclipse.ui.workbench_3.3.0.I20070608-1100.jar line 100, The constructor PropertyPageManager() is not accessible due to restriction on required library org.eclipse.ui.workbench_3.3.0.I20070608-1100.jar line 106, The method contribute(PropertyPageManager, Object) from the type PropertyPageContributorManager is not accessible due to restriction on required library org.eclipse.ui.workbench_3.3.0.I20070608-1100.jar line 82, The method getApplicableContributors(Object) from the type PropertyPageContributorManager is not accessible due to restriction on required library org.eclipse.ui.workbench_3.3.0.I20070608-1100.jar line 82, The method getManager() from the type PropertyPageContributorManager is not accessible due to restriction on required library org.eclipse.ui.workbench_3.3.0.I20070608-1100.jar line 106, The method getManager() from the type PropertyPageContributorManager is not accessible due to restriction on required library org.eclipse.ui.workbench_3.3.0.I20070608-1100.jar line 46, The type PropertyDialog is not accessible due to restriction on required library org.eclipse.ui.workbench_3.3.0.I20070608-1100.jar line 109, The type PropertyDialog is not accessible due to restriction on required library org.eclipse.ui.workbench_3.3.0.I20070608-1100.jar line 109, The type PropertyDialog is not accessible due to restriction on required library org.eclipse.ui.workbench_3.3.0.I20070608-1100.jar line 47, The type PropertyPageContributorManager is not accessible due to restriction on required library org.eclipse.ui.workbench_3.3.0.I20070608-1100.jar line 82, The type PropertyPageContributorManager is not accessible due to restriction on required library org.eclipse.ui.workbench_3.3.0.I20070608-1100.jar line 106, The type PropertyPageContributorManager is not accessible due to restriction on required library org.eclipse.ui.workbench_3.3.0.I20070608-1100.jar line 48, The type PropertyPageManager is not accessible due to restriction on required library org.eclipse.ui.workbench_3.3.0.I20070608-1100.jar line 100, The type PropertyPageManager is not accessible due to restriction on required library org.eclipse.ui.workbench_3.3.0.I20070608-1100.jar line 100, The type PropertyPageManager is not accessible due to restriction on required library org.eclipse.ui.workbench_3.3.0.I20070608-1100.jar
Until the platform team does something to make some of these internal classes public, we really can't do much about the warnings in this particular plug-in. Sorry.
No feedback from platform at this point. Pushing off to M4
Extracted all related discouraged access calls to a new utility class ProfileUIManager. Any additional calls to the Platform UI internal API should be added here as well. The warnings are still there, but at least encapsulated within an utility class for ease of future updates.
This appears to be as fixed as we can get it for Ganymede.
Related utility API methods have been added in org.eclipse.ui.dialogs.PreferencesUtil (see bug 208830) to support the usage in DTP. Re-opening this bug to use those new platform-ui methods.
DTP 1.6 needs to provide backward compatibility support of Eclipse platform 3.3, and the new API methods are added in 3.4 only. So for 1.6, updated DTP internal utility class ProfileUIManager to use a copy of the platform-ui methods instead. Leaving this bug open for the next major release, when DTP no longer needs to be backward compatible with 3.3. By then, we can directly use the API methods in o.e.ui.dialogs.PreferencesUtil, and completely remove the use of internal platform-ui package.
Created attachment 121195 [details] Patch Since backward compatibility to Platform version 3.3 is no longer supported in DTP 1.7, this patch switches from using internal Platform UI packages to Platform UI API methods added in 3.4 (Bugzilla 208830). This also updates the minimum version of a couple of plugin dependencies.
Brian, Can you please take a look at the patch, especially the updates to the minimum version of plugin dependencies? It seems that some other plugin dependencies should have their version tolerance updated as well.
Hi Linda... Your patch looks fine to me. I want to talk today about your question regarding minimum versions. But go ahead and deliver this to Galileo if you don't mind. Thanks for making sure this got resolved! --Fitz
Created attachment 121688 [details] Revised Patch Revised patch to increase the o.e.d.c.ui plugin version from 1.1.3 to 1.1.4.
Delivered latest patch to HEAD branch, tagged with v200901070440.
