Bug 201066 - [prefs] Preferences listeners are not removed while shutting down JavaModelManager
Summary: [prefs] Preferences listeners are not removed while shutting down JavaModelMa...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC All
: P3 major (vote)
Target Milestone: 3.4 M2   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-24 07:14 EDT by Frederic Fusier CLA
Modified: 2007-09-18 03:22 EDT (History)
1 user (show)

See Also:

Attachments
Proposed patch (43.07 KB, patch)
2007-08-28 05:04 EDT, Frederic Fusier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2007-08-24 07:14:31 EDT 
While initializing JavaModelManager, preferences listeners are set but they are not removed while shutting down!
Comment 1 Frederic Fusier CLA 2007-08-28 05:04:57 EDT 
Created attachment 77102 [details]
Proposed patch

Preferences listeners are now stored in JavaModelManager to remove them while shutting down.

This patch also gives easier access to indexManager and deltaState variables through static methods instead of using getJavaModelManager()...

UserLibraryManager is also no longer a preferences listener but just called by the existing one when the modified preference name starts with user library prefix.
Comment 2 Frederic Fusier CLA 2007-08-28 06:55:27 EDT 
Released for 3.4M2 in HEAD stream.
Comment 3 Eric Jodet CLA 2007-09-18 00:56:38 EDT 
(In reply to comment #2)
Verified in the code for 3.4 M2 using build I20070917-0010.