201044 – [pde] fragment wizard doesn't transfer host maximum version from wizard into manifest

Bug 201044 - [pde] fragment wizard doesn't transfer host maximum version from wizard into manifest

Summary: [pde] fragment wizard doesn't transfer host maximum version from wizard into ...

Status:	RESOLVED FIXED

Alias:	None

Product:	PDE
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	3.3
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	3.4 M2
Assignee:	Brock Janiczak
QA Contact:

URL:
Whiteboard:
Keywords:	bugday, contributed

Depends on:
Blocks:

Reported:	2007-08-24 03:03 EDT by Marco Lehmann-Mörz
Modified:	2007-08-27 13:41 EDT (History)
CC List:	3 users (show)

See Also:

Attachments
patch to org.eclipse.pde.ui (1.47 KB, patch) 2007-08-25 03:31 EDT, Brock Janiczak	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Marco Lehmann-Mörz

2007-08-24 03:03:59 EDT

Build ID: I20070625-1500

Steps To Reproduce:
1. Create a new fragment project
2. Choose your Host Plug-in
3. Enter Maximum version
4. Finish the wizard
5. The Plug-in Manifest Editor opens and the host maximum version is empty

Comment 1 Brock Janiczak

2007-08-25 03:31:08 EDT

Created attachment 76968 [details]
patch to org.eclipse.pde.ui

Updated to use the plugin version directly from IFragmentFieldData instead of using VersionRange to get the minimum version.

tested with both 3.3 and 3.0 fragments

Comment 2 Brian Bauman

2007-08-27 00:21:58 EDT

Brock, I like the patch.  Very simple.  Reduce PDE code count while making it work better.  Nice work ;-)

By the way, we still need a photo preferably with a leafy background for the contributors page.

Comment 3 Brian Bauman

2007-08-27 00:22:25 EDT

patch applied to HEAD.  Included in 3.4M2

Comment 4 Adam Archer

2007-08-27 13:41:05 EDT

I believe your options are as follows:

a) leafy background
b) patio/patio furniture background (see Janek's picture for an example)  :P

http://www.eclipse.org/pde/pde-ui/committers/committers.php