Bug 200840 - [TOC][Editor] 'Browse' in Link element allows you to nest a TOC in itself
Summary: [TOC][Editor] 'Browse' in Link element allows you to nest a TOC in itself
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M2   Edit
Assignee: Noam Chitayat CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-08-22 11:32 EDT by Noam Chitayat CLA
Modified: 2007-08-23 13:04 EDT (History)
1 user (show)

See Also:
mike.pawlowski: review+

Attachments
Patch for bug 200840. (6.86 KB, patch)
2007-08-22 17:48 EDT, Noam Chitayat CLA 		mike.pawlowski: review+
Details | Diff
Screen Shot #1 (17.56 KB, image/png)
2007-08-23 08:31 EDT, Mike Pawlowski CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Chitayat CLA 2007-08-22 11:32:01 EDT 
Build ID: 3.4 M1

1) Create a TOC.
2) Create a Link element in the TOC.
3) Select the Link element.
4) In the Link Details section, click 'Browse'
5) Find and select the TOC you're working on.
--> Bug: You are able to select this TOC, but this would lead to a cyclic linkage, which is NOT cool.
Comment 1 Noam Chitayat CLA 2007-08-22 17:48:51 EDT 
Created attachment 76719 [details]
Patch for bug 200840.

Browse and DND now use the same utility to check if the file in question is really the containing TOC. Both DND and Browse now prevent TOC self-nesting.
Comment 2 Mike Pawlowski CLA 2007-08-23 08:26:56 EDT 
Comment on attachment 76719 [details]
Patch for bug 200840.

Works well.  Thanks Noam.  Found one minor issue.  Details to follow.
Comment 3 Mike Pawlowski CLA 2007-08-23 08:29:26 EDT 
Patch released to HEAD.

Target:  3.4 M2

Minor Issue

Try dropping a TOC on itself using DND and notice that there is a flicker of a dialog box.  Using my quick cat like reflexes I was able to capture a screenshot of a progress dialog.  I'm not sure why that appears considering a successful drop has no dialog.  See screenshot #1.
Not sure if there is anything you can do about this ...
Comment 4 Mike Pawlowski CLA 2007-08-23 08:31:08 EDT 
Created attachment 76762 [details]
Screen Shot #1
Comment 5 Noam Chitayat CLA 2007-08-23 09:57:24 EDT 
Looks like a Package Explorer issue. Opened bug 200942.
Comment 6 Mike Pawlowski CLA 2007-08-23 13:04:38 EDT 
Fixed.