Bug 200803 - [Discovery] Provide a Composite Container for discovery
Summary: [Discovery] Provide a Composite Container for discovery
Status: CLOSED FIXED
Alias: None
Product: ECF
Classification: RT
Component: ecf.discovery (show other bugs)
Version: 1.0.2   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 2.0.0M4   Edit
Assignee: Markus Kuppe CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on: 209774
Blocks:
  Show dependency tree
 
Reported: 2007-08-22 07:31 EDT by Markus Kuppe CLA
Modified: 2008-05-18 19:43 EDT (History)
1 user (show)

See Also:


Attachments
first draft how a composite container might look like (63.60 KB, patch)
2007-09-10 06:12 EDT, Markus Kuppe CLA
no flags Details | Diff
version bump of this patch (20.06 KB, patch)
2007-09-24 07:23 EDT, Markus Kuppe CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Kuppe CLA 2007-08-22 07:31:59 EDT
Discovery consumer usually don't care about the specific container used to discover a certain service. Also they might want to use several discovery containers simultaneously while discovering for a service. Thus a CompositeContainer should be available that makes using more than one specific container transparent.
Comment 1 Markus Kuppe CLA 2007-09-10 06:12:58 EDT
Created attachment 77967 [details]
first draft how a composite container might look like
Comment 2 Markus Kuppe CLA 2007-09-24 07:23:43 EDT
Created attachment 79065 [details]
version bump of this patch
Comment 3 Markus Kuppe CLA 2007-10-11 11:08:33 EDT
"WRT CompositeDiscoveryContainer, I'm thinking of having a new Namespace and Container type (in new bundle) that 'knows' about both the JMDNS and SLP-providers...and their respective IServiceID and ServiceTypeID namespace.  It would probably be helpful also to define an extension point for such a bundle that allows other discovery providers to be contributed at load (extension) or run time (API)."

What do you think about having a new bundle o.e.discovery.util where we implement the CompositeDiscoveryContainer? I could start with it on ecf1.osuosl.org.
Comment 4 Scott Lewis CLA 2007-10-11 12:36:28 EDT
(In reply to comment #3)
> "WRT CompositeDiscoveryContainer, I'm thinking of having a new Namespace and
> Container type (in new bundle) that 'knows' about both the JMDNS and
> SLP-providers...and their respective IServiceID and ServiceTypeID namespace. 
> It would probably be helpful also to define an extension point for such a
> bundle that allows other discovery providers to be contributed at load
> (extension) or run time (API)."
> 
> What do you think about having a new bundle o.e.discovery.util where we
> implement the CompositeDiscoveryContainer? I could start with it on
> ecf1.osuosl.org.
> 

Sure.  Let's call it org.eclipse.ecf.provider.discovery.  If you would like to start on ecf1.osuosl.org that would be great.  I would suggest just creating it at dev.eclipse.org, but since you don't have commit rights for ECF that's not an option right now.  Would you like to become an ECF committer Markus?
Comment 5 Markus Kuppe CLA 2007-10-11 17:28:54 EDT
(In reply to comment #4)
> Sure.  Let's call it org.eclipse.ecf.provider.discovery.  If you would like to
> start on ecf1.osuosl.org that would be great.

I'll start working on it tomorrow on osuosl.org.

> I would suggest just creating it
> at dev.eclipse.org, but since you don't have commit rights for ECF that's not
> an option right now.  Would you like to become an ECF committer Markus?
> 

Lets have a vote, shall we?

Btw. if I later transfer my work from osuosl.org -> dev.eclipse.org as an official Eclipse committer, do we get around the CQ thingy?
Comment 6 Scott Lewis CLA 2007-10-11 17:30:30 EDT
(In reply to comment #5)
> (In reply to comment #4)
> > Sure.  Let's call it org.eclipse.ecf.provider.discovery.  If you would like to
> > start on ecf1.osuosl.org that would be great.
> 
> I'll start working on it tomorrow on osuosl.org.
> 
> > I would suggest just creating it
> > at dev.eclipse.org, but since you don't have commit rights for ECF that's not
> > an option right now.  Would you like to become an ECF committer Markus?
> > 
> 
> Lets have a vote, shall we?

Of course.  I was just asking if you wanted to do this.

> 
> Btw. if I later transfer my work from osuosl.org -> dev.eclipse.org as an
> official Eclipse committer, do we get around the CQ thingy?
> 

No...I wish it were so, but it's not.
Comment 7 Scott Lewis CLA 2007-10-16 15:34:45 EDT
Setting target milestone to 2.0.0M4
Comment 8 Markus Kuppe CLA 2008-05-05 07:18:25 EDT
Fixed in HEAD (some time ago)
Comment 9 Scott Lewis CLA 2008-05-18 19:43:01 EDT
closing.