Community
Participate
Working Groups
If you export packages via the Runtime tab on the Manifest editor, the popup dialog should have a filter similar to the Import Packages popup dialog but slightly different. It should be "Show non-java packages" and it shouldn't be check by default.
This is a nice one for the bugday in August for me. The popup dialog should initially show only Java packages and after the checkbox has been checked the non java packages too.
Thanks for taking this! Your algorithm is spot on, only java packages at first then allow the user to add non-java packages if they select the filter.
If you need inspiration, take a look at ImportPackageSection and how it does the filtering. I'm attaching a Mylyn context to help you out if you use Mylyn which will bring up these two files automatically for you.
Created attachment 77031 [details] mylyn/context/zip
I can take it :) maybe i won't have time at friday but in such case i will take care about it during the weekend :)
Ok it's to early in the morning to notice that it's already taken ;) sorry Joern :)
Thanks for the Mylyn context. That was very helpful. I compared the handleAdd() methods in ImportPackageSection and ExportPackageSection. ExportPackageSection uses the PDEJavaHelper.getPackageFragments() method and the PackageSelectionDialog to obtain and show the packages. I replaced this dialog with the ConditionalListSelectionDialog that is used in the ImportPackageSection. I use the same pattern including the Runnable and the BusyIndicator. At the moment i am not sure what a "non-Java package" is. I assume, when IPackageFragment.containsJavaResources() is false. If this is wrong, please correct me. I looked at the filtering code in ImportPackageSection.setElements() method, but i think it is easier to reuse the PDEJavaHelper.getPackageFragments() and to filter the packages returned with containsJavaResources(). Patch will follow ...
Created attachment 77171 [details] Patch for defect 200757
Created attachment 77172 [details] mylyn/context/zip
Works beautifully. By the way, if you want to help out another project that hasn't received that much love this week for bugday, Platform Debug has a simple one open: https://bugs.eclipse.org/bugs/show_bug.cgi?id=51710
Created attachment 77187 [details] mylyn/context/zip
updated milestone
setting to M2
