Bug 200756 - ExportPackageDialogLabelProvider not used?
Summary: ExportPackageDialogLabelProvider not used?
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M2   Edit
Assignee: Remy Suen CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed
Depends on:
Blocks:
 
Reported: 2007-08-22 00:37 EDT by Chris Aniszczyk CLA
Modified: 2007-08-28 11:38 EDT (History)
2 users (show)

See Also:


Attachments
Patch to remove the class and the subsequent list of unused imports. (6.78 KB, patch)
2007-08-28 07:46 EDT, Remy Suen CLA
no flags Details | Diff
Oh, here's the right one. :( (3.17 KB, patch)
2007-08-28 10:28 EDT, Remy Suen CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2007-08-22 00:37:15 EDT
In ExportPackageSection, looks like this isn't referenced anywhere...
Comment 1 Brian Bauman CLA 2007-08-22 00:43:49 EDT
I was actually going to fix that when I fixed the bidi problem.  So if no one takes it for this month's bugday, I will :)
Comment 2 Remy Suen CLA 2007-08-28 07:46:45 EDT
Created attachment 77120 [details]
Patch to remove the class and the subsequent list of unused imports.
Comment 3 Brian Bauman CLA 2007-08-28 10:23:53 EDT
Hi Remy, I will go ahead and assign you the bug since you attached a patch, but you might want to go back and look at the patch.  It seems there might have been some confusion some where as the patch submitted seems to be to a different bug :)
Comment 4 Remy Suen CLA 2007-08-28 10:28:11 EDT
Created attachment 77135 [details]
Oh, here's the right one. :(
Comment 5 Chris Aniszczyk CLA 2007-08-28 10:29:38 EDT
That's what Mylyn is for Remy ;)
Comment 6 Brian Bauman CLA 2007-08-28 11:38:01 EDT
Thanks Remy!  I applied the patch as is.  

The only thing I added was removing a PDEUIMessages and pderesources.properties entry which the ExportPackageDialogLabelProvider referenced.  The entries were no longer referenced by anyone.

Good luck with the patch for the other bug ;-)

Also, we have a page with the photos of all the PDE UI Committers and Contributors (http://www.eclipse.org/pde/pde-ui/committers/committers.php).  Since you have now contributed to the component, we would love to put your picture up with everyone else's.  If you can, please send me a head shot with preferably a leafy background and we will make sure you make it up there :)