Community
Participate
Working Groups
20020612 suspecting jcore problem (fields are the only sub-cu things we delete by calling ISourceManipulation::delete) deleting even 1 takes a while deleting more than 1 is really slow (autobuild OFF)
Philippe, any comments on this ? May be you know something before we do some performance traces.
Perf analysis is always good. I am guessing that if the file is big, everything will take a while, even parsing for reconciling the model and issuing deltas.
Actually, I'll let you do initial investigation. I wouldn't be too surprised if multiple UI actions where triggered (reconcile, refresh cool markers, etc...) all at once.
Created attachment 2554 [details] deleting a field 70% is SourceRefElement.delete
What was the testcase? How big was the file? From the trace, half the time seems to in WorkingCopy.save(). Deleting a single field doesn't seem that slow to me but deleting multiple fields at once is updating the editor over & over again.
the test case was deleting 1 field from a file of 2000 lines
Please provide the test case as an attachment in this PR.
Any plans to address this in 2.1?
Recently we noticed that JDT/UI was performing 2 field deletions as 2 separate operations, even though the deletion operation can operate on a set of fields. Deleting all fields at once is already an improvement. Now even one seems slow already (but more than one should no longer be pathetic). Could be some extra reconciliation etc... Will revisit post 2.1
As of now 'LATER' and 'REMIND' resolutions are no longer supported. Please reopen this bug if it is still valid for you.