Bug 20038 - deleting fields is slow on large files [ccp]
Summary: deleting fields is slow on large files [ccp]
Status: RESOLVED WONTFIX
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-Core-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2002-06-12 11:36 EDT by Adam Kiezun CLA
Modified: 2009-08-30 02:21 EDT (History)
1 user (show)

See Also:


Attachments
deleting a field (9.74 KB, text/plain)
2002-11-28 06:02 EST, Adam Kiezun CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Kiezun CLA 2002-06-12 11:36:31 EDT
20020612
suspecting jcore problem (fields are the only sub-cu things we delete by calling
ISourceManipulation::delete)

deleting even 1 takes a while 
deleting more than 1 is really slow
(autobuild OFF)
Comment 1 Dirk Baeumer CLA 2002-07-30 12:40:52 EDT
Philippe, any comments on this ? May be you know something before we do some 
performance traces.
Comment 2 Philipe Mulet CLA 2002-07-31 06:15:20 EDT
Perf analysis is always good. I am guessing that if the file is big, everything 
will take a while, even parsing for reconciling the model and issuing deltas.
Comment 3 Philipe Mulet CLA 2002-10-23 16:14:52 EDT
Actually, I'll let you do initial investigation. I wouldn't be too surprised if 
multiple UI actions where triggered (reconcile, refresh cool markers, etc...) 
all at once.

Comment 4 Adam Kiezun CLA 2002-11-28 06:02:24 EST
Created attachment 2554 [details]
deleting a field

70% is SourceRefElement.delete
Comment 5 Kent Johnson CLA 2002-11-28 14:40:31 EST
What was the testcase? How big was the file?

From the trace, half the time seems to in WorkingCopy.save().

Deleting a single field doesn't seem that slow to me but deleting multiple 
fields at once is updating the editor over & over again.
Comment 6 Adam Kiezun CLA 2002-11-29 05:01:52 EST
the test case was deleting 1 field from a file of 2000 lines
Comment 7 Olivier Thomann CLA 2002-12-13 13:54:56 EST
Please provide the test case as an attachment in this PR.
Comment 8 Jeff McAffer CLA 2003-02-10 12:10:41 EST
Any plans to address this in 2.1?
Comment 9 Philipe Mulet CLA 2003-03-05 06:18:05 EST
Recently we noticed that JDT/UI was performing 2 field deletions as 2 separate 
operations, even though the deletion operation can operate on a set of fields.
Deleting all fields at once is already an improvement.

Now even one seems slow already (but more than one should no longer be 
pathetic). Could be some extra reconciliation etc...

Will revisit post 2.1
Comment 10 Denis Roy CLA 2009-08-30 02:21:02 EDT
As of now 'LATER' and 'REMIND' resolutions are no longer supported.
Please reopen this bug if it is still valid for you.