Community
Participate
Working Groups
SystemViewRemoteFileAdapter#internalGetChildren() is synchronized, but calls out to other methods below it. This construct could deadlock easily, since it is very similar to the one fixed with bug #199552 -- see the comments there for information how the deadlock actually happened. Please investigate why you think the method must be synchronized, and either get rid of the synchronized statement or find an alternative way of synchronization. Take care of bug #149188 comment 4, it shows one reason why the synchronized could be there.
For similar issues, see also bug 199565 and bug 199566.
See bug #199573 comment 1 for an example how to fix issues with synchronized.
Note that because there is only a single instance of the SystemViewRemoteFileAdapter, if ANY connection locks that one object through internalGetChildren(), NO other "remote files" connections will be able to get any children any more. This is obvious from the backtrace in bug 202758 comment 1, where an FTP connection gets stalled because the remote server doesn't answer any more. Due to the "synchronized" statements, no other connections will be able to get children; and, what's more, if any internalGetChildren() call should happen on a display thread, ALL of Eclipse will be stalled. Please re-think the situation why you believe this should be synchronized and try to come up with a solution (perhaps eliminating the "synchronized" statement).
I tried taking out the synchronized for both SystemViewRemoteFileAdapter and I haven't been running into any concurrency issues. I do however see a couple of additional calls to IFileService.getFile() on the main thread (by the table view when it tries to compute layout and by the system view when it's trying to determine matching filters). I'm not sure if those can easily be avoided without risky changes right now. At least the synchronized doesn't seem to be required. Do you think it's safe enough to remove it at this stage?
Take it out now, before the test pass this thursday. Even if we should run into trouble, the synchronized here is certainly not the right solution for it.
Created attachment 78073 [details] patch to remove synchronized Here is the patch to remove the synchronized from internalGetChildren
Patch is good, as discussed.
I've committed the patch for this to cvs.
