199431 – Add Singleton checkbox to Fragment Manifest Editor

Bug 199431 - Add Singleton checkbox to Fragment Manifest Editor

Summary: Add Singleton checkbox to Fragment Manifest Editor

Status:	RESOLVED FIXED

Alias:	None

Product:	PDE
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	3.4
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	3.4 M2
Assignee:	Peter Friese
QA Contact:

URL:
Whiteboard:
Keywords:	bugday, contributed

Depends on:
Blocks:

Reported:	2007-08-09 10:18 EDT by Brian Bauman
Modified:	2007-09-03 11:42 EDT (History)
CC List:	2 users (show)

See Also:

Attachments
Patch that adds singleton to plug-in and fragments. (7.23 KB, patch) 2007-08-11 17:55 EDT, Peter Friese	no flags	Details \| Diff
mylyn/context/zip (1.54 KB, application/octet-stream) 2007-08-11 17:55 EDT, Peter Friese	no flags	Details
Patch with better labels for the singleton checkbox. (5.39 KB, patch) 2007-09-03 03:18 EDT, Peter Friese	no flags	Details \| Diff
mylyn/context/zip (3.70 KB, application/octet-stream) 2007-09-03 03:18 EDT, Peter Friese	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Brian Bauman

2007-08-09 10:18:00 EDT

In 3.4M1, Peter was nice enough to supply the Plugin Manifest Editor with an UI to set the singleton value on the Bundle-SymbolicName header.  This should be included in the Overview page of the Fragment Manifest Editor also.

Comment 1 Peter Friese

2007-08-09 12:06:33 EDT

I'll take it - need another T-Shirt :-)

Comment 2 Wassim Melhem

2007-08-09 19:06:30 EDT

Peter, one word:  leafy!  You are ruining our photo album with some kind of desert background :)

Comment 3 Peter Friese

2007-08-10 04:24:41 EDT

 (In reply to comment #2)
> Peter, one word:  leafy!  You are ruining our photo album with some kind of
> desert background :)
In fact, what you believe to be a desert is the sea bed of the North Sea :-) But fear not, I will come up with a leafy photo eventually.

Comment 4 Peter Friese

2007-08-11 17:55:37 EDT

Created attachment 75913 [details]
Patch that adds singleton to plug-in and fragments.

Comment 5 Peter Friese

2007-08-11 17:55:39 EDT

Created attachment 75914 [details]
mylyn/context/zip

Comment 6 Brian Bauman

2007-08-13 15:02:36 EDT

Patch Applied.  Thanks for the patch Peter!

The only modification I did was to move the code that refreshes the Singleton button into the GeneralInfoSection.refresh() instead of in each subclass's refresh function.  Cuts down on code :)

Comment 7 Wassim Melhem

2007-09-01 22:58:44 EDT

The label for the checkbox should say "This fragment is a singleton", NOT "This plug-in is a singleton".

Comment 8 Peter Friese

2007-09-03 03:18:15 EDT

Created attachment 77564 [details]
Patch with better labels for the singleton checkbox.

Wassim is right - the labels should be clearer. I changed the implementation accordingly.

Comment 9 Peter Friese

2007-09-03 03:18:18 EDT

Created attachment 77565 [details]
mylyn/context/zip

Comment 10 Chris Aniszczyk

2007-09-03 11:42:52 EDT

thanks Peter! committed to HEAD.