Community
Participate
Working Groups
Build ID: I20070625-1500 Steps To Reproduce: 1. Open an editor or chatroom 2. Write: irc://foobar@freenode.net/#eclipse-bugs 3. <Ctrl> + Click 4. IRC Connection Wizard shows as connection id: "modlost@freenode.net/" instead of "irc://foobar@freenode.net/#eclipse-bugs" More information: This problems appears only if '#' is used to specify the channel.
Created attachment 75702 [details] First approach I also notice that "irc://foobar@freenode.net/#channel1,#channel2" is not hyperlinked because URI class [0] throws: java.net.URISyntaxException: Illegal character in fragment at index 33: irc://modlost@foobar.com/#channel,#foobar Everything works fine with URI's like: irc://foobar@freenode.net/channel1 irc://foobar@freenode.net/channel1,channel2 Should IRC Hyperlink support more than one channel with '#'? [0] org.eclipse.ecf.ui.hyperlink.AbstractURLHyperlinkDetector.detectProtocol()
(In reply to comment #1) > Created an attachment (id=75702) [details] > First approach > > I also notice that "irc://foobar@freenode.net/#channel1,#channel2" is not > hyperlinked because URI class [0] throws: > > java.net.URISyntaxException: Illegal character in fragment at index 33: > irc://modlost@foobar.com/#channel,#foobar > > Everything works fine with URI's like: > > irc://foobar@freenode.net/channel1 > irc://foobar@freenode.net/channel1,channel2 > > Should IRC Hyperlink support more than one channel with '#'? > > [0] org.eclipse.ecf.ui.hyperlink.AbstractURLHyperlinkDetector.detectProtocol() > I'm of the opinion that it should not. I would like to stick with well-formed URI syntax if at all possible...and the '#' is a fragment delimiter in URI syntax, so having more than one complicates things.
(In reply to comment #2) > I'm of the opinion that it should not. I would like to stick with well-formed > URI syntax if at all possible...and the '#' is a fragment delimiter in URI > syntax, so having more than one complicates things. I agree, supporting more than one '#' will be complicated. Well, I think that my first approach patch could add support for just one '#'.
(In reply to comment #3) > (In reply to comment #2) > > I'm of the opinion that it should not. I would like to stick with well-formed > > URI syntax if at all possible...and the '#' is a fragment delimiter in URI > > syntax, so having more than one complicates things. > > I agree, supporting more than one '#' will be complicated. Well, I think that > my first approach patch could add support for just one '#'. > Does the current attachment to this bug do the desired thing (i.e. support irc://irc.freenode.net/#eclipse-dev? Or should I wait for another patch before applying, testing, etc. Thanks.
(In reply to comment #4) > > Does the current attachment to this bug do the desired thing (i.e. support > irc://irc.freenode.net/#eclipse-dev? Yes, it does. You can apply it and test it :)
Tested, verified, committed after some minor changes. Added contribution to IP log. Thanks much Abner. Please keep them coming.
closing.
