Bug 199285 - [terminal][api][breaking] TerminalConnector ID should be mandatory in plugin.xml
Summary: [terminal][api][breaking] TerminalConnector ID should be mandatory in plugin.xml
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: Terminal (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.0 M5   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2007-08-08 12:35 EDT by Martin Oberhuber CLA
Modified: 2008-02-05 13:01 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2007-08-08 12:35:50 EDT 
ITerminalConnectorInfo.getId() is defined but the ID is optional; in case it is not given, the "class" attribute is used instead.

This is confusing and should be avoided.
The ID attribute of the TerminalConnector should be mandatory.
Comment 1 Michael Scharf CLA 2007-10-02 21:06:45 EDT 
I made the 'id' attribute required in the schema
Comment 2 Michael Scharf CLA 2007-10-05 09:02:02 EDT 
made the ID optional again to not break existing clients
Comment 3 Martin Oberhuber CLA 2008-01-07 10:04:17 EST 
Did not make the fix for M4, targeting 3.0M5
Comment 4 Martin Oberhuber CLA 2008-02-05 13:01:52 EST 
Fixed in terminalConnector.exsd

The Terminal Connector ID is now mandatory, since it is part of a connector's API to be identifiable by its id. Having this ID as part of its public API is important because only this allows refactoring its implementation class or package if necessary.