Bug 199276 - [archives] Creating a folder with an archive extension causes errors.
Summary: [archives] Creating a folder with an archive extension causes errors.
Status: NEW
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P4 minor (vote)
Target Milestone: Future   Edit
Assignee: Xuan Chen CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2007-08-08 11:27 EDT by Rupen Mardirossian CLA
Modified: 2010-05-26 15:19 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rupen Mardirossian CLA 2007-08-08 11:27:31 EDT
-----------Enter bugs above this line-----------
installation : eclipse-SDK-3.3RC4 
RSE install  : RSE-DEV
java.runtime : Sun 1.5.0_06-b05
os.name:     : Windows XP 5.1, Service Pack 2
Comment 1 Rupen Mardirossian CLA 2007-08-08 11:40:02 EDT
When creating a file with an archive extension, creating files in this folder/archive causes problem.

1)Right click in a filter or directory -> New -> Folder
2)Name the folder 'new.zip' or 'new.jar'
3)Try and create a file in this folder/archive (file is not created)

Problem seen in both local and Dstore

Console message (seen in local when double clicking) :

Access is denied
Could not open zipfile: D:\rupen.zip

Sometimes... in local when double clicking on the folder/archive an error window will open with a NPE exception. log:

!ENTRY org.eclipse.jface 4 2 2007-08-08 11:35:00.283
!MESSAGE Problems occurred when invoking code from plug-in: "org.eclipse.jface".
!STACK 0
java.lang.NullPointerException
	at org.eclipse.rse.internal.files.ui.view.SystemViewRemoteFileAdapter.filterChildren(SystemViewRemoteFileAdapter.java:730)
	at org.eclipse.rse.internal.files.ui.view.SystemViewRemoteFileAdapter.internalGetChildren(SystemViewRemoteFileAdapter.java:671)
	at org.eclipse.rse.internal.files.ui.view.SystemViewRemoteFileAdapter.getChildren(SystemViewRemoteFileAdapter.java:550)
	at org.eclipse.rse.internal.ui.view.SystemViewLabelAndContentProvider.getChildren(SystemViewLabelAndContentProvider.java:342)
	at org.eclipse.jface.viewers.AbstractTreeViewer.getRawChildren(AbstractTreeViewer.java:1317)
	at org.eclipse.jface.viewers.TreeViewer.getRawChildren(TreeViewer.java:366)
	at org.eclipse.jface.viewers.AbstractTreeViewer.getFilteredChildren(AbstractTreeViewer.java:615)
	at org.eclipse.jface.viewers.AbstractTreeViewer.getSortedChildren(AbstractTreeViewer.java:581)
	at org.eclipse.rse.internal.ui.view.SystemView.access$4(SystemView.java:1)
	at org.eclipse.rse.internal.ui.view.SystemView$7.run(SystemView.java:5959)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:67)
	at org.eclipse.rse.internal.ui.view.SystemView.createChildren(SystemView.java:5940)
	at org.eclipse.jface.viewers.AbstractTreeViewer.setExpandedState(AbstractTreeViewer.java:2360)
	at org.eclipse.rse.internal.ui.view.SystemView.handleDoubleClick(SystemView.java:534)
	at org.eclipse.rse.internal.ui.view.SystemView$1.doubleClick(SystemView.java:468)
	at org.eclipse.jface.viewers.StructuredViewer$1.run(StructuredViewer.java:799)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:37)
	at org.eclipse.core.runtime.Platform.run(Platform.java:857)
	at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:46)
	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:193)
	at org.eclipse.jface.viewers.StructuredViewer.fireDoubleClick(StructuredViewer.java:797)
	at org.eclipse.jface.viewers.AbstractTreeViewer.handleDoubleSelect(AbstractTreeViewer.java:1384)
	at org.eclipse.jface.viewers.StructuredViewer$4.widgetDefaultSelected(StructuredViewer.java:1173)
	at org.eclipse.jface.util.OpenStrategy.fireDefaultSelectionEvent(OpenStrategy.java:237)
	at org.eclipse.jface.util.OpenStrategy.access$0(OpenStrategy.java:234)
	at org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java:295)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:938)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3682)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3293)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2389)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2353)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2219)
	at org.eclipse.ui.internal.Workbench$4.run(Workbench.java:466)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:289)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:461)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:106)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:153)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:106)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:76)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:363)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:504)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:443)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1169)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1144)



-----------Enter bugs above this line-----------
installation : eclipse-SDK-3.3RC4 
RSE install  : RSE-DEV
java.runtime : Sun 1.5.0_06-b05
os.name:     : Windows XP 5.1, Service Pack 2
_______________________________________________
Comment 2 Martin Oberhuber CLA 2007-08-08 12:19:59 EDT
I'm currently looking at something that's probably related, in the LocalFileSystem.

I think that what we should always take into account is this:

  * If a file physically exists, it cannot be virtual (even if it has #virtual#
    somewhere in its path

  * If something is a folder, it cannot be an archive (even if it has *.zip
    extension)

I'm just not sure whether these checks should be right in the ArchiveHandlerManager, or in the services that use the archive handlers...
Comment 3 Martin Oberhuber CLA 2007-08-09 06:40:16 EDT
See also bug #199394.
Comment 4 Martin Oberhuber CLA 2007-10-01 07:57:28 EDT
Bulk update target milestone 2.0.1 -> 3.0
Comment 5 Martin Oberhuber CLA 2008-12-03 13:33:28 EST
Xuan you didn't mention this bug in the team meeting today, but it is assigned 3.0.2 -- please consider changing the target milestone, or commit it today.