Bug 199149 - Manifest highlighting needed in other PDE refactoring areas
Summary: Manifest highlighting needed in other PDE refactoring areas
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Adam Archer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-08-07 15:14 EDT by Brian Bauman CLA
Modified: 2007-08-07 23:40 EDT (History)
1 user (show)

See Also:

Attachments
patch (13.36 KB, patch)
2007-08-07 15:50 EDT, Adam Archer CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Bauman CLA 2007-08-07 15:14:26 EDT 
There are a few areas in PDE where we refactor Manifest files which do not have Manifest syntax highlighting.  Adam has been working hard to make the Organize Manifest and Externalize Wizards so pretty, it has made the other PDE refactoring look ugly by comparison.

We need to help spread the beauty though more of PDE refactoring so none of the current refactoring classes feel like ugly step children.
Comment 1 Adam Archer CLA 2007-08-07 15:50:22 EDT 
Created attachment 75580 [details]
patch

Created a public static method, PDEModelUtility#setChangeTextType(TextFileChange, IFile), that sets the text type on the change parameter based on the type of file in the IFile parameter.

This method is now called for all TextFileChanges created by PDE refactoring participants and for the change created by the Rename Plug-in ID wizard.

Also removed calls to deprecated methods on ITextFileBufferManager by adding LocationKing.NORMALIZE parameters.
Comment 2 Wassim Melhem CLA 2007-08-07 23:40:49 EDT 
I think we are all in agreement that Adam is awesome.