Bug 199122 - Feature Export multitarget export broken
Summary: Feature Export multitarget export broken
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.4 M2   Edit
Assignee: Patrick Dempsey CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-08-07 13:06 EDT by Patrick Dempsey CLA
Modified: 2007-09-10 18:59 EDT (History)
1 user (show)

See Also:
baumanbr: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Dempsey CLA 2007-08-07 13:06:10 EDT 
while looking at bug 199005 I found that I could not Export...->Deployable Features to multiple targets as the name of the plugin containing the targets has changed from org.eclipse.platform.launcher to org.eclipse.equinox.executable

Fix is:
org.eclipse.pde.internal.ui.wizards.exports.FeatureExportWizard.addPages()
-IFeatureModel model = manager.findFeatureModel("org.eclipse.platform.launchers"); //$NON-NLS-1$
+IFeatureModel model = manager.getDeltaPackFeature();

org.eclipse.pde.internal.ui.wizards.exports.FeatureOptionsTab.addCrossPlatformOption(Composite comp)
-IFeatureModel model = manager.findFeatureModel("org.eclipse.platform.launchers"); //$NON-NLS-1$
+IFeatureModel model = IFeatureModel model = manager.getDeltaPackFeature();
Comment 1 Brian Bauman CLA 2007-09-10 18:55:37 EDT 
Patrick, you should definitely be entered in the most unique way to post a patch ;-)

Next time, feel free to create a patch, save it on your file system, and attach it to the bug.

Either way, you were right on with the fix.  It worked great.  I am assigning the bug to you so you get "credit" for the bug.
Comment 2 Brian Bauman CLA 2007-09-10 18:59:50 EDT 
So now that you fixed a PDE bug, we need a photo of you with a leafy background for the contributor page (http://www.eclipse.org/pde/pde-ui/committers/committers.php).

Welcome to the elite club of PDE contributors!