Bug 199098 - [Schema][Editors] Duplicate names are allowed from source page
Summary: [Schema][Editors] Duplicate names are allowed from source page
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M4   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2007-08-07 11:44 EDT by Adam Archer CLA
Modified: 2007-12-11 12:00 EST (History)
1 user (show)

See Also:

Attachments
mylyn/context/zip (763 bytes, application/octet-stream)
2007-11-30 06:07 EST, Chris Aniszczyk CLA 		no flags Details
org.eclipse.pde.core.patch (6.16 KB, patch)
2007-12-05 09:32 EST, Chris Aniszczyk CLA 		no flags Details | Diff
mylyn/context/zip (1.43 KB, application/octet-stream)
2007-12-05 09:32 EST, Chris Aniszczyk CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Archer CLA 2007-08-07 11:44:12 EDT 
The fix for bug 196866 overlooked one case. Currently the user can manually give two local attributes or two global elements the same name by using the source page.

As a fix for this I would recommend auto generating a new name during the model creation similarly to the discussions in bug 196866 comment 2 and bug 196685.
Comment 1 Brian Bauman CLA 2007-10-26 19:09:13 EDT 
We should be able to provide some validation to notify the user when this happens.  We already have schema validation, we just need to add this functionality.
Comment 2 Chris Aniszczyk CLA 2007-11-30 06:07:04 EST 
Adding context.
Comment 3 Chris Aniszczyk CLA 2007-11-30 06:07:12 EST 
Created attachment 84156 [details]
mylyn/context/zip
Comment 4 Chris Aniszczyk CLA 2007-12-05 09:32:10 EST 
Created attachment 84528 [details]
org.eclipse.pde.core.patch

Flags duplicate elements as errors. I also extracted some text into constants.
Comment 5 Chris Aniszczyk CLA 2007-12-05 09:32:14 EST 
Created attachment 84529 [details]
mylyn/context/zip
Comment 6 Chris Aniszczyk CLA 2007-12-05 09:32:51 EST 
Fixed in HEAD.

Thanks for the bug report Adam.
Comment 7 Brian Bauman CLA 2007-12-11 12:00:46 EST 
verified on I20071211-0010.