Bug 199031 - [api] AbstractSystemWizardPage should not implement ISystemMessageLine
Summary: [api] AbstractSystemWizardPage should not implement ISystemMessageLine
Status: NEW
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: Future   Edit
Assignee: dsdp.tm.rse-inbox CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2007-08-07 05:13 EDT by Uwe Stieber CLA
Modified: 2007-08-07 09:37 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Uwe Stieber CLA 2007-08-07 05:13:14 EDT 
The implementation of AbstractSystemWizardPage can be made more reliable, smaller and better extendable if dropping the use of ISystemMessageLine for this page. The messages are already redirected into the standard wizard message area and a cleanup of the API and implementation should be done to remove unnecessary code.
Comment 1 Martin Oberhuber CLA 2007-08-07 09:22:26 EDT 
I agree that AbstractSystemWizardPage should not implement ISystemMessageLine. Changed the Summary (previous value was:
  "Cleanup AbstractSystemWizardPage implementation and remove ISystemMessageLine  from list of implemented interfaces"

What we could do instead of implementing ISystemMessageLine, but still support the ISystemMessageLine (or similar IMessageManager) API for allowing RSE Widgets to print their messages to it, is have a getter:

  public ISystemMessageLine AbstractSystemWizardPage#getMessageLine();

though an even better solution would be to replace ISystemMessageLine by a more reliable and versatile interface like UI Forms / IMessageManager, see bug 199025.