Bug 198982 - UI support for additional table and column settings
Summary: UI support for additional table and column settings
Status: RESOLVED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 2.0 M6   Edit
Assignee: Pascal Filion CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-08-06 17:19 EDT by Neil Hauge CLA
Modified: 2008-10-21 16:42 EDT (History)
3 users (show)

See Also:


Attachments
Added new settings to Column pane and Join Column dialog (88.86 KB, patch)
2008-03-24 12:29 EDT, Pascal Filion CLA
no flags Details | Diff
Added missing UI support (112.45 KB, patch)
2008-03-26 14:43 EDT, Pascal Filion CLA
no flags Details | Diff
Added the missing settings and fixed several bugs in the dialogs (114.79 KB, patch)
2008-03-28 11:34 EDT, Pascal Filion CLA
neil.hauge: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Neil Hauge CLA 2007-08-06 17:19:01 EDT
Currently we do not have UI support for many of the secondary values for Table and Column.  The example for Table is uniqueContraints, for Column would be nullable, length, etc.  

The primary elements of Table and Column should remain in the main area of a given composite, while the primary and secondary elements could be located in a expandable composite specifically for Table or Column.  This keeps them out of the way for normal mapping use, but accessible for those who want to define the DB schema in the code, or for other uses.
Comment 1 Karen Butzke CLA 2008-03-21 09:21:06 EDT
We decided to support Column as follows:

Name : ________________
Column : ________________
> Details    (no border on this twistie)
   + Insertable (tri-state check box)
   + Updatable
   + Unique
   + Nullable
   - Length (spinner)
   - Precision
   - Scale


All Join Column dialogs will have a Details twistie as well which will have the 4 checks boxes : Insertable, Updatable, Unique, Nullable. Not positive if the twistie is necessary on a dialog, so Pascal how about not doing the twistie and we'll see how it looks?

This bug will not handle the missing Table widgets (I think that's only unique constraints).

Comment 2 Karen Butzke CLA 2008-03-21 09:21:44 EDT
Discriminator Column is missing a setting for length, I don't think that one setting would warrant a twistie.  Neil, do we want to support this setting in our UI?
Comment 3 Pascal Filion CLA 2008-03-24 12:29:39 EDT
Created attachment 93290 [details]
Added new settings to Column pane and Join Column dialog

The twistie in the dialog doesn't seem to work well since the dialog is by default not-resizable.
Comment 4 Neil Hauge CLA 2008-03-24 12:44:59 EDT
(In reply to comment #2)
> Discriminator Column is missing a setting for length, I don't think that one
> setting would warrant a twistie.  Neil, do we want to support this setting in
> our UI?
> 

We are also missing columnDefinition, both of which would be used for the purpose of DDL Generation.  That would make 2 widgets to hide.  I don't think either of these 2 settings will be commonly used, but they do seem to go well with the rest of the additions under this bug.  Let's come back to it if Pascal has enough time.

Other thoughts?


Comment 5 Karen Butzke CLA 2008-03-25 10:42:32 EDT
Checked in this patch.
Remaining work for this bug:
1. 'column definition' support
2. 'primary key join column' dialog needs extra settings
3. 'join column' in 'join table' dialog needs extra settings


Will create separate bugs for 'discriminator column; settings and 'table' settings
Comment 6 Pascal Filion CLA 2008-03-26 14:43:22 EDT
Created attachment 93660 [details]
Added missing UI support

Also:
1. The default value is now shown to the right of a spinner
2. Fixed an issue in ControlAligner and updated its test
Comment 7 Karen Butzke CLA 2008-03-26 14:59:05 EDT
Checked in this patch.  Remaining work is now:
2. 'primary key join column' dialog needs extra settings
3. 'join column' in 'join table' dialog needs extra settings
Comment 8 Pascal Filion CLA 2008-03-28 11:34:19 EDT
Created attachment 93983 [details]
Added the missing settings and fixed several bugs in the dialogs
Comment 9 Karen Butzke CLA 2008-03-31 10:41:30 EDT
Checked these changed in to HEAD, will be included in M6
Comment 10 David Williams CLA 2008-04-24 00:49:12 EDT
mass change to add 'contributed' keyword based on bugzilla query, please
correct if that's not accurate (by marking patches as obsolete and removing the
'contributed' keyword.