Bug 198819 - [telnet] TelnetConnectorService does not send CommunicationsEvent.BEFORE_CONNECT
Summary: [telnet] TelnetConnectorService does not send CommunicationsEvent.BEFORE_CONNECT
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.1.1   Edit
Assignee: Anna Dushistova CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2007-08-03 11:12 EDT by Martin Oberhuber CLA
Modified: 2009-08-02 08:10 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2007-08-03 11:12:20 EDT 
DStoreConnectorSErvice#internalConnect() is currently the only connector service that sends CommunicationsEvent.BEFORE_CONNECT.

All connector services should do so. Sending the event might be a good idea in the AbstractConnectorService base class.

The event may be important for clients to register such that they can tweak the operation of the connector service just before it connects, e.g. supply a password out of a hidden database.
Comment 1 Anna Dushistova CLA 2008-05-15 10:35:47 EDT 
Martin, SshConnectorService#internalConnect() also sends CommunicationsEvent.BEFORE_CONNECT, it doesn't make any sense for Local, so the only service that doesn't have fireCommunicationsEvent(CommunicationsEvent.BEFORE_CONNECT);
in it is TelnetConnectorService.
Comment 2 Martin Oberhuber CLA 2008-09-16 15:51:33 EDT 
Bulk update of target milestone
Comment 3 Martin Oberhuber CLA 2009-06-17 11:13:27 EDT 
Ok, good point. Anna can you care for telnet in 3.1.1 ?

I still think we should consider the API aspect. It's too easy for RSE extensions to get this wrong, the framework (AbstractConnectorService) should care for it.

And we should also check TCF and file a bug for TCF in case it doesn't send the event.
Comment 4 Anna Dushistova CLA 2009-08-02 08:04:07 EDT 
Done for telnet. Checked TCF--it looks like neither BEFORE_CONNECT nor BEFORE_DISCONNECT events are sent. I'll open a separate bug for it.
Comment 5 Anna Dushistova CLA 2009-08-02 08:10:09 EDT 
Bug 285373 is created to track TCF issue.