Bug 198615 - [TOC][Editors] NLS processing instruction is not generated
Summary: [TOC][Editors] NLS processing instruction is not generated
Status: RESOLVED INVALID
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.4 M4   Edit
Assignee: Noam Chitayat CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2007-08-02 00:05 EDT by Wassim Melhem CLA
Modified: 2007-11-15 15:14 EST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wassim Melhem CLA 2007-08-02 00:05:12 EDT 
All the existing toc.xml in the SDK have this processing instructions:
<?NLS TYPE="org.eclipse.help.toc"?>

I believe it is used to signal to the translation teams to translate these xml files.

cc Curtis to comment on whether we should generate it by default.  I suspect that we should.
Comment 1 Brian Bauman CLA 2007-08-02 09:26:29 EDT 
Hey Noam, since you are doing a lot of work on the TOC editor, can you take care of this bug?  

Mike can review any patches.  If he doesn't have time, let me know and I can review them.
Comment 2 Curtis d'Entremont CLA 2007-08-02 10:33:31 EDT 
Kit, do you still need "<?NLS TYPE="org.eclipse.help.toc"?>" for help toc files?
Comment 3 Kit Lo CLA 2007-08-02 10:39:50 EDT 
Yes! Translators have different markup tables for different type of XML files telling them what should be translated, and what should be protected. Thanks!
Comment 4 Chris Aniszczyk CLA 2007-11-11 21:35:24 EST 
Noam, how about one for good old times?
Comment 5 Chris Aniszczyk CLA 2007-11-12 21:09:19 EST 
Hey Kit Lo, aren't about 100% of TOC's generated from within the big blue fortress? This string also doesn't really apply to anyone but us.

Also, if the NLS string is already in the TOC, we won't strip it out if the editor is used and we save the TOC.

I'm considering closing this bug as INVALID if you can't give me a better reason :D
Comment 6 Chris Aniszczyk CLA 2007-11-15 15:14:42 EST 
reopen if it's an issue.