Bug 198576 - [Filters] Renaming a folder directly under a Filter doesn't update children
Summary: [Filters] Renaming a folder directly under a Filter doesn't update children
Status: CLOSED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.0.1   Edit
Assignee: Kevin Doyle CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-08-01 15:14 EDT by Kevin Doyle CLA
Modified: 2011-05-25 09:35 EDT (History)
1 user (show)

See Also:

Attachments
SystemViewRemoteFileAdapter no longer fires a refresh event, instead the rename event does the refresh (4.81 KB, patch)
2007-08-01 15:32 EDT, Kevin Doyle CLA 		no flags Details | Diff
Updated with comments. (5.23 KB, patch)
2007-08-01 16:32 EDT, Kevin Doyle CLA 		mober.at+eclipse: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Doyle CLA 2007-08-01 15:14:57 EDT 
Renaming a folder directly under a filter will update the the folders name, but none of it's children of that folder are updated.  Double clicking on any of the folders/files under the renamed folder doesn't work till you do a refresh.

-----------Enter bugs above this line-----------
TM 2.0.1 Testing
installation : eclipse-SDK-3.3
RSE install  : Dev Driver 
java.runtime : Sun 1.5.0_11-b03
os.name:     : Windows XP, Service Pack 2
------------------------------------------------
Comment 1 Kevin Doyle CLA 2007-08-01 15:32:17 EDT 
Created attachment 75156 [details]
SystemViewRemoteFileAdapter no longer fires a refresh event, instead the rename event does the refresh

This patch does the following:

1. Removes the fired EVENT_REFRESH_REMOTE from SystemViewRemoteFileAdapter.doRename().  
2. SystemView's handling of SYSTEM_REMOTE_RESOURCE_RENAMED now refreshes the renamed object if it has children. 

We also no longer lose the selection when doing a rename!

Legal Message: I, Kevin Doyle, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL. I am authorized by my employer, IBM Canada Ltd. to make this
contribution under the EPL.
Comment 2 David McKnight CLA 2007-08-01 16:18:31 EDT 
Could you add some comments to explain why you commented out that code that was there in the adapter?  We'll probably want to get rid of the code altogether, but for now, it would be nice to leave it commented with an explanation why it's not used anymore.
Comment 3 Kevin Doyle CLA 2007-08-01 16:32:14 EDT 
Created attachment 75167 [details]
Updated with comments.

Updated to include comments for why the refresh event was commented out.
Comment 4 David McKnight CLA 2007-08-01 16:43:20 EDT 
I've committed the changes.  Thanks.
Comment 5 Kevin Doyle CLA 2007-09-13 11:56:16 EDT 
Verified fixed with 2.0.1RC1.