Bug 198175 - Double-click should expand nodes
Summary: Double-click should expand nodes
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M1   Edit
Assignee: bartosz michalik CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed
Depends on:
Blocks:
 
Reported: 2007-07-27 21:31 EDT by Wassim Melhem CLA
Modified: 2007-07-31 14:41 EDT (History)
3 users (show)

See Also:
baumanbr: review+


Attachments
doubleclick on TreeSelection descenants (3.59 KB, patch)
2007-07-31 10:38 EDT, bartosz michalik CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wassim Melhem CLA 2007-07-27 21:31:01 EDT
In the PDE editors, we have many sections depicting trees, where double-clicking on a tree node does nothing.

By default, double-clicking should expand a collapsed node and collapse an expanded node (a la Package Explorer).

I suspect we can fix all the PDE cases by modifying the TreeSection superclass.
Comment 1 Wassim Melhem CLA 2007-07-30 10:08:49 EDT
The next bugday won't occur for a month.  You want me to wait for a month to see it?  ;)
Comment 2 Chris Aniszczyk CLA 2007-07-30 10:16:27 EDT
I commend the PDE team for tagging bugs as 'bugday' already.

This is a good sign and good habit that we should get into.
Comment 3 Brian Bauman CLA 2007-07-30 10:24:15 EDT
Wassim, I only want to make you happy.

If you look at the track record for bugday bugs, you might notice we actually
get patches on days other than the actual bug day.  It appears (or I am
guessing) that people in the community use the bugday keyword as an indicator
on which bugs they should fix.  I guess I could use the helpWanted keyword, but
thought bugday is sufficient.

If bugday was in a week, this would be a great candidtate.  If no one has shown
interest and tried to fix this in a week or so and you can't wait to see this functionality, I will personally see to it that it gets fixed ;-)
Comment 4 Wassim Melhem CLA 2007-07-30 14:43:15 EDT
Thanks Brian. 

God knows I don't ask for much ;)
Comment 5 Wassim Melhem CLA 2007-07-31 08:46:31 EDT
Assigning to Bartek.
Comment 6 Wassim Melhem CLA 2007-07-31 09:08:56 EDT
Brian to assist Bartek and review his patch.
Comment 7 bartosz michalik CLA 2007-07-31 10:38:25 EDT
Created attachment 75037 [details]
doubleclick on TreeSelection descenants
Comment 8 Brian Bauman CLA 2007-07-31 13:39:18 EDT
Patch worked great.  I committed it with only one minor change to ExtensionsSection.  Since the doubleClick function was empty, instead of calling the 'super' function, I just removed it.  The code which was commented out in the function is extremely old.

Thanks for the solid patch (that and in just a few hours)!
Comment 9 Chris Aniszczyk CLA 2007-07-31 14:08:54 EDT
thanks, adding contributed keyword.
Comment 10 Wassim Melhem CLA 2007-07-31 14:14:32 EDT
Brian, 
Bartek is covered by the IBM copyright in the Java file, so no need to add his name to the file itself.

Bartek, we will need a picture with a leafy background for the PDE/UI committers and contributors page.  I am sure you can find a tree in Poznan.
Comment 11 Wassim Melhem CLA 2007-07-31 14:41:40 EDT
Until we receive an official picture, we will use a placeholder :)

http://www.eclipse.org/pde/pde-ui/committers/committers.php