Bug 198132 - [IRC] client occassionally says "null"
Summary: [IRC] client occassionally says "null"
Status: CLOSED FIXED
Alias: None
Product: ECF
Classification: RT
Component: ecf.providers (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.0.2   Edit
Assignee: Cagatay Calli CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed
Depends on:
Blocks:
 
Reported: 2007-07-27 12:51 EDT by Jacek Pospychala CLA
Modified: 2007-08-05 15:57 EDT (History)
0 users

See Also:
caniszczyk: review? (slewis)

Attachments
"Null Join Message" Bug Patch (2.43 KB, patch)
2007-07-27 14:55 EDT, Cagatay Calli CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacek Pospychala CLA 2007-07-27 12:51:42 EDT 
When using IRC client it occassionally says "null".
Sometimes on public channel, sometimes on private.
"null" is really sent to the irc server, as I observed it having conversation between two clients: chatzilla and ECF. Chatzilla printed that ECF client said "null".

that may be effect of intensive BugDay efforts.
Comment 1 Cagatay Calli CLA 2007-07-27 14:55:41 EDT 
Created attachment 74824 [details]
"Null Join Message" Bug Patch
Comment 2 Chris Aniszczyk CLA 2007-07-27 17:18:22 EDT 
This should go into 1.0.2, setting Scott to review and commit.
Comment 3 Scott Lewis CLA 2007-07-27 17:37:04 EDT 
(In reply to comment #1)
> Created an attachment (id=74824) [details]
> "Null Join Message" Bug Patch
> 

Hi Cagatay...I'm reviewing this patch and there's a line 

		} else {
			String output = processForCommand(null, text);
			if(output != null){
				sendMessageLine(processForCommand(null, text));
			}
		}

Would this work correctly if this was changed to:

		} else {
			String output = processForCommand(null, text);
			if(output != null) sendMessageLine(output);
		}

The 'processForCommand' was called twice, with apparently the same input.  If
there are no side effects in processForCommand then this change should be OK and
I will commit it.  Could you advise?  Thanks.
Comment 4 Cagatay Calli CLA 2007-07-27 17:45:56 EDT 
Ah sorry Chris, I would do the exact thing. It seems I overlooked it. :) Thanks.
Comment 5 Scott Lewis CLA 2007-07-27 17:55:26 EDT 
(In reply to comment #4)
> Ah sorry Chris, I would do the exact thing. It seems I overlooked it. :)
> Thanks.
> 

OK...great.  I've made change to patch and committed to HEAD.  Marking this bug as fixed.  If this doesn't fix the problem, then please reopen.

Thanks Catagay for your contribution.
Comment 6 Scott Lewis CLA 2007-08-05 15:57:20 EDT 
Updated IP log.  Closing.  Thanks again Cagatay for your contribution.