Community
Participate
Working Groups
To replicate: 1)Create a folder in local -> folder1 2)Create 2 subfolders - > move1, move2 3)Select both folders -> Right click -> Move 4)In the dialog box you are not allowed to move the folders to move1, but are allowed to move them to move2. If you press ok to move into the second subfolder... only the first one will be moved. Although, niether should be allowed if I am not mistaken. -----------Enter bugs above this line----------- installation : eclipse-SDK-3.3RC4 RSE install : RSE-devdriver java.runtime : Sun 1.5.0_06-b05 os.name: : Windows XP 5.1, Service Pack 2 ------------------------------------------------ systemtype : Linux - dstore ------------------------------------------------
Looks like the validator for the move-to-location needs to 1.) Be fed with the full selection of all source items to move 2.) Check whether the destination folder to validate is a parent of any of the source folders chosen. I think that the bug is minor - assigning to Kevin since you have dealt with Validators before, but it is really low priority IMHO.
Also, there is the issue that when you select Move it selects the parent folder of the files to be moved and the Okay button is enabled, but should be disabled. If you select another folder then go back to the parent folder the Okay button is disabled.
Created attachment 75263 [details] Go through all files to be moved when checking if valid Legal Message: I, Kevin Doyle, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I am authorized by my employer, IBM Canada Ltd. to make this contribution under the EPL.
The patch looks good. Just a bit confused with the following message (which is used when the source folder itself or its parent is selected as target folder): Target folder cannot equal source folder: Details: Attempting to move a file or folder to the same folder as it exists in is equivalent to a rename operation. Use the rename action for this. The level one message is more applicatable to the situation where user selects the source folder as the target folder. The level two message is more applicable to the situation where user selects the parent of the source folder as the target folder. Maybe we need to open a bug to improve the message contents when translation is possible. I will committ the patch.
Committed the patch.
I've committed the patch.
I have verified that this defect has been fixed with the dev driver. I am closing now.
