Community
Participate
Working Groups
With this request I want to offer contribution - connectivity support for MAXDB database. I have prepared two plugins – one for the database definition (XMI) and one for specific MAXDB implementation – DDL generator, builder and small enhancements, specific for MAXDB. The plugins are tested in SAP developer studio. If you are interested about such contribution, please tell me and I will attach the patches with the relevant plugins.
We would be pleased to review your contribution as an attachment to the bugzilla entry. --Brian Fitzpatrick (DTP Connectivity)
Created attachment 79769 [details] MAXDB database definition and specific enhancements
Hello Brian, At last we received permission to provide MAXDB XMI to DTP. The attached ZIP (see comment#2)contains all we want to contribute – XMI, which describes MAXDB and enhancements, specific for MAXDB. The structure of the attached folder is plugin structure. In the applied DBConfiguration and TableConstraintLoader I have described (as comment) what the purpose of the implementation is, and which bugzilla entry we have workarounded. If you have some questions, don’t hesitate to contact me. The separation of XMI definition and implementation if it’s necessary I’m leaving on you. From my side I have only one question. We haven’t implemented tests for this stuff yet and unfortunately I couldn’t find exemplary tests in CVS for other database enablement plugins. If you have requirements for test coverage, please give me and example and/or short description which kind of testing you prefer : unit test, functionality test, etc. Best Regards, Dimiter
Dimiter, Thank you for this contribution! We'll start the Eclipse review procedure for bringing this code into the DTP code line, and certainly will get back to you with status and questions.
Hello John, I forgot to mention, that we prefer to contribute this stuff for Ganymede release. The reason is, that it's immature yet and we plan to develop it during the following months. Best Regards, Dimiter
Hey Dimiter... Your MaxDB contribution looks great. A couple of things to note... 1) We're still planning on supporting JDK 1.4.x, not just JDK 1.5, so all JDK 1.5 features (like <> and @override indicators) need to be removed 2) The assert class you use in MaxDbTableConstraintLoader should be org.eclipse.core.runtime.Assert. I think this is also a JDK 1.5 thing. Other than that, it worked and looked fine. We appreciate the help in the enablement area adding additional DBMS types! --Fitz
Approved
Pending Eclipse IP review and determination of committer resources.
IP review completed by Eclipse legal. Wolfgang Auer nominated as committer for this component.
Asking for Brian's review w.r.t the Enablement "best practices" doc Initial tm for 1.6 set, pending committer election, build integration and testing.
Hi John... Based on what's in this contribution, it appears pretty straightforward to get it in line with the enablement doc... The one plug-in would be split into two plug-ins. The dbdefinition and its extension would go into its own plug-in (o.e.d.e.sap.maxdb.dbdefinition) and you could simply rename the o.e.d.e.maxdb plugin to match the form that Larry established for best practices: o.e.d.e.sap.maxdb. It doesn't appear that a o.e.d.e.sap.maxdb.ui plug-in is necessary for this stage in development, but could be created with a readme.txt indicating that that is where any custom UI-related code would go. Let me know if you have any other questions, but this should be pretty straightforward to do. --Fitz
Assigning to Wolfgang, since he is now the component lead for this.
A inital contribution for MaxDB is done.
Closing bugs
