Community
Participate
Working Groups
For example, say you see this in the IRC UI: (23:31:10) irc.freenode.net: whois pombreda (23:31:10) irc.freenode.net: pombreda@c-71-204-153-28.hsd1.ca.comcast.net (23:31:10) irc.freenode.net: channels: #fedora-java #gentoo-java #trac #seagull #udig #weblogic-eclipse #jfire #rssowl #jbosstools #eclipse-ecf #phpeclipse #eclipse-dev #easyeclipse #eclipse #eclipse-commits It would be nice to ctrl+click those and join a channel within your existing connection. I'm marking this as bugday but this one may be a bit tricky.
Created attachment 75243 [details] Patch to add chat room hyperlink Eclipse Bug Day is over but I want to continue to contribute to ECF. BTW, this patch is for plugins: org.eclipse.ecf.presence.ui, org.eclipse.ecf.provider.irc and org.eclipse.ecf.provider.irc.ui The hard part was to find a way to get a reference to ChatRoomManagerView and IRCRootContainer. I've used extension org.eclipse.ui.workbench.texteditor.hyperlinkDetectorTargets and IRCChannelContainer.getAdapter(), but I'm not sure this is the best solution. If there is a better way, please, tell me and I'll fix it.
I've just notice that chat room hyperlink only works in channel tabs, I'll update the patch to support hyperlink in server tab.
Created attachment 75267 [details] Patch to add chat room hyperlink (update) With this patch the hyperlink support works in channel tabs y server tab, it's a little different that the previous patch.
This hyperlink would theoretically show up for all chatrooms (which would include non-IRC ones). Is there a way to get around this?
(In reply to comment #4) > This hyperlink would theoretically show up for all chatrooms (which would > include non-IRC ones). Is there a way to get around this? I think there should be a way. I'll work on it.
Created attachment 94158 [details] Patch Patch updated. The targetId is based on provider, so now the hyperlink will only show up in IRC Chatrooms.
Created attachment 94159 [details] mylyn/context/zip
Testing patch 94158.
Applied patch 94158, tested, updated IP log. Thanks very much Abner! It's highly appreciated!
(In reply to comment #9) > Applied patch 94158, tested, updated IP log. Thanks very much Abner! It's > highly appreciated! thanks for your words :D I've just notice that I forgot to add the copyright & license comment at the beginning of IRCChannelHyperlinkDetector and IRCChannelHyperlink classes.
(In reply to comment #10) > (In reply to comment #9) > > Applied patch 94158, tested, updated IP log. Thanks very much Abner! It's > > highly appreciated! > > thanks for your words :D > > I've just notice that I forgot to add the copyright & license comment at the > beginning of IRCChannelHyperlinkDetector and IRCChannelHyperlink classes. > If you put the desired copyright on this bug as a patch I will apply it to these two classes.
closing.
