Bug 197604 - [IRC] kick, ban, unban, op, deop commands cause parse error.
Summary: [IRC] kick, ban, unban, op, deop commands cause parse error.
Status: CLOSED FIXED
Alias: None
Product: ECF
Classification: RT
Component: ecf.providers (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Jacek Pospychala CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed
Depends on:
Blocks:
 
Reported: 2007-07-24 04:02 EDT by Jacek Pospychala CLA
Modified: 2007-08-05 16:05 EDT (History)
0 users

See Also:

Attachments
test case (3.22 KB, patch)
2007-07-24 04:04 EDT, Jacek Pospychala CLA 		no flags Details | Diff
patch (5.86 KB, text/plain)
2007-07-24 04:07 EDT, Jacek Pospychala CLA 		no flags Details
test case (4.58 KB, patch)
2007-07-24 04:40 EDT, Jacek Pospychala CLA 		no flags Details | Diff
patch (6.00 KB, patch)
2007-07-24 04:41 EDT, Jacek Pospychala CLA 		no flags Details | Diff
mylyn/context/zip (1.08 KB, application/octet-stream)
2007-07-24 10:48 EDT, Chris Aniszczyk CLA 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacek Pospychala CLA 2007-07-24 04:02:31 EDT 
Please see the attached test...

IRC version from HEAD.
Comment 1 Jacek Pospychala CLA 2007-07-24 04:04:04 EDT 
Created attachment 74424 [details]
test case
Comment 2 Jacek Pospychala CLA 2007-07-24 04:07:34 EDT 
Created attachment 74425 [details]
patch

patch makes test pass.
Comment 3 Jacek Pospychala CLA 2007-07-24 04:40:05 EDT 
Created attachment 74430 [details]
test case

whops, there was a bug in nextToken
Comment 4 Jacek Pospychala CLA 2007-07-24 04:41:13 EDT 
Created attachment 74431 [details]
patch
Comment 5 Chris Aniszczyk CLA 2007-07-24 10:37:08 EDT 
looking into it
Comment 6 Chris Aniszczyk CLA 2007-07-24 10:48:04 EDT 
released to HEAD with minor string externalization changes
Comment 7 Chris Aniszczyk CLA 2007-07-24 10:48:09 EDT 
Created attachment 74470 [details]
mylyn/context/zip
Comment 8 Chris Aniszczyk CLA 2007-08-02 04:10:50 EDT 
reopening to make proper assignment.
Comment 9 Chris Aniszczyk CLA 2007-08-02 04:11:10 EDT 
bug should be assigned to Jacek
Comment 10 Jacek Pospychala CLA 2007-08-03 18:04:01 EDT 
marking as fixed, since it's in head.
Comment 11 Scott Lewis CLA 2007-08-05 15:59:09 EDT 
Updated IP log, closing.  Thanks Jacek for this contribution.
Comment 12 Jacek Pospychala CLA 2007-08-05 16:05:26 EDT 
you welcome Scott! I am hoping to contribute something more, specially into integrating different message views, and some other "[IRC] ...", but I was out of time recently.