Bug 197385 - [launcher] free called twice on exitData if default error dialog is displayed
Summary: [launcher] free called twice on exitData if default error dialog is displayed
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Framework (show other bugs)
Version: 3.3   Edit
Hardware: PC Linux-GTK
: P3 normal (vote)
Target Milestone: 3.4   Edit
Assignee: Andrew Niefer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
: 195086 198840 199651 (view as bug list)
Depends on:
Blocks: 197639
  Show dependency tree
 
Reported: 2007-07-20 21:17 EDT by Kelly Campbell CLA
Modified: 2008-06-19 14:54 EDT (History)
3 users (show)

See Also:

Attachments
One line patch to fix double-free (736 bytes, patch)
2007-07-20 21:19 EDT, Kelly Campbell CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kelly Campbell CLA 2007-07-20 21:17:40 EDT 
Build ID: I20070621-1340

Steps To Reproduce:
1. Use a debug version of a glibc that asserts errors on double-free
2. Run eclipse and kill jvm
3. eclipse core dumps due to double free assertion


More information:
eclipse.c assigns errorMsg = exitData and then free's both, so the free of exitData in this case is incorrect.

patch included
Comment 1 Kelly Campbell CLA 2007-07-20 21:19:38 EDT 
Created attachment 74286 [details]
One line patch to fix double-free
Comment 2 Andrew Niefer CLA 2007-07-24 09:20:02 EDT 
released in HEAD, Binaries will be recompiled for I20070731
Comment 3 Andrew Niefer CLA 2007-08-13 11:16:51 EDT 
*** Bug 198840 has been marked as a duplicate of this bug. ***
Comment 4 Andrew Niefer CLA 2007-08-13 11:39:52 EDT 
*** Bug 195086 has been marked as a duplicate of this bug. ***
Comment 5 Andrew Niefer CLA 2008-06-19 14:54:01 EDT 
*** Bug 199651 has been marked as a duplicate of this bug. ***