Community
Participate
Working Groups
It would be nice if we had a control or something in the UI that represented the channel name and topic. Also a way to set this would be awesome!
Likely to require additional API. Setting target milestone to 1.1.0 (first API additions).
(In reply to comment #1) > Likely to require additional API. I don't think we have any API, period. We have an IChatRoomAdminListener to listen for subject change events but I couldn't find anything to _set_ the subject.
(In reply to comment #2) > (In reply to comment #1) > > Likely to require additional API. > > I don't think we have any API, period. Well, I think that's incorrect...as you go onto say... >We have an IChatRoomAdminListener to > listen for subject change events but I couldn't find anything to _set_ the > subject. True, that's why it's... > > Likely to require additional API. So, perhaps someone should propose additional API to meet the 'set' need implied by bug...in concert with the requested UI additions.
;P What I meant is, "I don't think it's _likely_ it's we _must add_ additional API because I can't find any topic _setting_ API.' But anyway... I would've said IChatRoomContainerOptionsAdapter, but it's not really exactly an "option" in the preferences sense...
I've added: in org.eclipse.ecf.presence.chatroom: IChatRoomAdminSender (an chat room admin interface that allows the sending of a subject/topic change message) and to existing interface IChatRoomContainer IChatRoomAdminSender getChatRoomAdminSender(); I've also provided implementations: IRCRootContainer: returns null. IRCChannelContainer: returns IChatRoomAdminSender that sends a topic update to the appropriate channel XMPPChatRoomContainer: returns IChatRoomAdminSender that sends a subject update to the appropriate channel There remains the implementation of some UI for sending the subject update message
I've added a @since tag to the interface.
(In reply to comment #6) > I've added a @since tag to the interface. > Thanks.
I've added a read-only text field above the chat text fields that displays the subject. I'll leave it to an eager bug day participant to finish this bug off. :)
(In reply to comment #8) > I've added a read-only text field above the chat text fields that displays the > subject. I'll leave it to an eager bug day participant to finish this bug off. > :) > Let's say the I'm the eager bug day participant ;) and I need some help. I found where the code, which would update the topic field, should go, but I'm not sure how I should get the IChatRoomAdminSender instance. In the class ChatRoomManagerView I have access to the instance of IRCRootContainer (the container filed in the mentioned class), but it returns null on invoking getChatRoomAdminSender(); I wonder how can I access instance of IRCChannelContainer, which would let me get the instance of IChatRoomAdminSender on invoking getChatRoomAdminSender();?
(In reply to comment #9) > I wonder how can I access instance of IRCChannelContainer, which would let me > get the instance of IChatRoomAdminSender on invoking > getChatRoomAdminSender();? You can retrieve the SWT Text widget from the ChatRoomTab in ChatRoom class. Its constructor also takes in the IChatRoomContainer, so you can get the interface from there.
(In reply to comment #10) > > You can retrieve the SWT Text widget from the ChatRoomTab in ChatRoom class. > Its constructor also takes in the IChatRoomContainer, so you can get the > interface from there. Yes, I know that. But when I try to invoke IChatRoomContainer#getChatRoomAdminSender on the instance of IChatRoomContainer, which is available there, I get null instead of instance of IChatRoomAdminSender. And this is beacause the IChatRoomContainer is the instance of IRCRootContainer and not IRCChannelContainer.
(In reply to comment #11) > But when I try to invoke > IChatRoomContainer#getChatRoomAdminSender on the instance of > IChatRoomContainer, which is available there, I get null instead of instance of > IChatRoomAdminSender. And this is beacause the IChatRoomContainer is the > instance of IRCRootContainer and not IRCChannelContainer. I don't, I get an IRCChannelContainer. We're talking about the constructor at line 721 of the ChatRoomManagerView, yes?
Created attachment 79363 [details] Patch attachment Thanks Remy for the tip. I prepared a patch, but I'm not sure if I had used the simplest solution. Looking forward for any comments.
Committed to CVS HEAD with some slight adjustments. Thanks, Jakub.
closing
