Bug 197129 - [api][breaking] Remove obsolete ISystemConnectionWizardPropertyPage and SystemSubSystemsPropertiesWizardPage
Summary: [api][breaking] Remove obsolete ISystemConnectionWizardPropertyPage and Syste...
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.0 M3   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on: 174789
Blocks: 176490
  Show dependency tree
 
Reported: 2007-07-19 08:50 EDT by Martin Oberhuber CLA
Modified: 2007-11-14 08:39 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2007-07-19 08:50:08 EDT 
The classes
   ISystemConnectionWizardPropertyPage
   SystemSubSystemsPropertiesWizardPage
are part of a legacy mechanism for showing Subsystem Property Pages (i.e. which are registered against an ISubSystem) as part of the new connection wizard.

This mechanism is removed due to performance issues as listed in bug #174789. Therefore, the related classes should also be removed such that implementors are aware that the mechanism is no longer in place.

A replacement of this mechanism is to override SubsystemConfigurationAdapter.getWizardPages() in order to return custom wizard pages. Re-using property pages inside such custom wizard pages might be investigated as part of a larger effort to improve the new connection wizard UI (bug #176490).
Comment 1 Martin Oberhuber CLA 2007-07-19 09:00:45 EDT 
When making this API change, the method

class SubSystemConfigurationAdapter {
  protected List getSubSystemPropertyPages(ISubSystemConfiguration config)
}

should also be removed, because 
 - the existing Platform functionality for contributing property pages should
   be used only
 - the objectClass attribute is deprecated, and the code does not check the new
   <enableWhen> property
 - the method is no longer used inside RSE
Comment 2 David McKnight CLA 2007-11-05 12:52:28 EST 
I've removed the obsolete code.