Community
Participate
Working Groups
Following classes are nowhere used and seem to be obsolete: SystemViewConnectionSelectionInputProvider SystemSelectConnectionAction SystemSelectConnectionDialog (*) SystemSelectConnectionForm (*) SystemUpdateConnectionDialog SystemUpdateConnectionAction SystemRemoteArchiveSelectAction SystemRemoteFileSelectAction SystemRemoteFolderSelectAction SystemRemoteConnectionCombo (*) SystemWidgetHelpers.createSystemTypeListBox (*) (*) SystemSelectConnectionDialog and SystemRemoteConnectionCombo are in an API package so removing those is an API change and might require proposing an alternative. The others are in internal packages so removing them should not be an issue.
Assigning 2.0.1 for now since I'd like the non-api-changing removals to be done for 2.0.1
Note: Occurrences of the obsolete classes have been found by searching who's calling SystemWidgetHelpers.getValidSystemTypes() -- this check should be re-done once obsolete classes are removed.
Bulk update target milestone 2.0.1 -> 3.0
Created attachment 82097 [details] patch for removing obsolete classes
I've added a patch for removing the obsolete classes. For those that are in API packages, do you think we need to do anything? Is so, how do we go about proposing alternatives?
Since you remove the API classes as well, I'm marking this bug as [api][breaking] in the subject. I guess that in the final 3.0 release, we should have a "migration" section in the ISV docs, similar to http://help.eclipse.org/help33/nav/2_3 While it's not clear if and how we compile that migration section, I'd propose just adding your migration notes as a comment on this bug, in the form of "If you've been using SystemRemoteConnectionCombo, migrate to using XYZ instead". When compiling the migration docs, all bugs which are marked as [api][breaking] should be considered for inclusion.
In place of SystemSelectConnectionForm, users may use SystemHostCombo to choose an available connection. In place of the SystemRemoteFileSelectAction and the SystemRemoteFolderSelectAction, users should use the SystemSelectRemoteFolderAction. As an alternative, users can use SystemRemoteArchiveDialog, SystemRemoteFileDialog and SystemRemoteFolderDialog directly. In place of the SystemRemoteConnectionCombo, users should use the SystemHostCombo directly or via SystemWidgetHelpers.createConnectionCombo(). In place of SystemWidgetHelpers.createSystemTypeListBox(), users can use SystemWidgetHelpers.createListBox() directly with the appropriate arguments. Martin, do you think this description is sufficient? I've committed the changes to cvs.
Looks good to me.
Okay, I'm marking this as fixed now.
