Community
Participate
Working Groups
Create a connection of type "SSH Only". Window > Preferences > Remote Systems, disable "SSH Only" connection type, OK. --> SSH connection still shown in System view; Do View-menu > Refresh all and it is gone. Quit and re-start RSE. --> The SSH connection is shown in the System View; Verify in Preferences that the connection type is switched off. Do View-menu > Refresh all and it is gone. Expected behavior: The SSH Only connection should not be shown in the SystemView after restart. It looks like a ViewContentProvider does not check the adapter for systemType enablement as it should: RSESystemTypeAdapter a = systemType.getAdapter(RSESystemTypeAdapter.class); if (a.isEnabled(systemType)) { ... -----------Enter bugs above this line----------- TM 2.0 installation : eclipse-SDK-3.3 (I20070625-1500), cdt-4.0.0, emf-2.3.0 RSE install : workspace HEAD java.runtime : Sun 1.6.0_01-b06 os.name: : Windows XP 5.1, Service Pack 1 ------------------------------------------------ systemtype : Windows-local, Dstore-win, Dstore-linux targetos : Red Hat Enterprise Linux WS release 4 (Nahant Update 3) targetuname : Linux parser 2.6.9-34.EL #1 i686 athlon i386 GNU/Linux targetvm : Sun Java HotSpot(TM) Client VM (build 1.4.2_12-b03, mixed mode) ------------------------------------------------
Note: this happened with the old Workspace persistence provider (on an old workspace that had been created with RSE 1.x).
The initial rendering of the view is fine however the createHost() calls in the registry fire new host events, causing the tree to add the ssh connection. I've fixed this by checking the host enablement in the event handling.
Hmm... shouldn't it also return Status.OK_STATUS right away when systemTYpe==null ? Also, you are not checking the case where adapter==null
(In reply to comment #3) > Hmm... shouldn't it also > return Status.OK_STATUS > right away when systemTYpe==null ? > > Also, you are not checking the case where adapter==null > I've updated it as per comments.