Bug 196898 - add method to IScriptModel interface to lookup projects by nature id
Summary: add method to IScriptModel interface to lookup projects by nature id
Status: RESOLVED FIXED
Alias: None
Product: DLTK
Classification: Technology
Component: Common (show other bugs)
Version: 0.95   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Dmitriy Kovalev CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks: 198190
  Show dependency tree
 
Reported: 2007-07-17 22:54 EDT by Jae Gangemi CLA
Modified: 2010-06-11 07:17 EDT (History)
2 users (show)

See Also:

Attachments
implemenation patch (4.57 KB, patch)
2007-07-17 22:54 EDT, Jae Gangemi CLA 		no flags Details | Diff
implemenation patch (4.61 KB, patch)
2007-07-17 23:06 EDT, Jae Gangemi CLA 		alex.panchenko: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jae Gangemi CLA 2007-07-17 22:54:34 EDT 
the attached patch adds a method to the IScriptModel interface (and implementation) that retrieves all script projects based upon the project nature id. 

this will be used by a forth coming patch that will only display projects associated with the specified launch configuration (instead of showing all dltk script projects like it does now).

and it seems like it would be a useful method to have in general :)
Comment 1 Jae Gangemi CLA 2007-07-17 22:54:56 EDT 
Created attachment 74023 [details]
implemenation patch
Comment 2 Jae Gangemi CLA 2007-07-17 22:57:25 EDT 
oh yeah, this patch also replaces the javadoc @see comments w/ regular old comments since it makes mousing over the method to read it's javadoc somewhat useless - that information is inherited by default if nothing is specified.
Comment 3 Jae Gangemi CLA 2007-07-17 23:06:25 EDT 
Created attachment 74025 [details]
implemenation patch

d'oh - submitted the wrong patch
Comment 4 Eclipse Webmaster CLA 2007-07-29 09:23:24 EDT 
Changing OS from Mac OS to Mac OS X as per bug 185991
Comment 5 Dmitriy Kovalev CLA 2007-07-31 03:32:46 EDT 
Thanks for patch, but your code has problems with closed projects because 'hasNature' method can be called without the CoreException only when project is opened. So, I've added method 'IScriptProject[] getOpenedScriptProjects(String natureId) throws ModelException' to IScriptModel interface. I think this method has the same semantic as you mean.
Comment 6 Andrey Platov CLA 2008-05-26 02:49:18 EDT 
bulk change: fixed in 0.95